After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775209 - 3.23.2.1 not buildable from tarball
3.23.2.1 not buildable from tarball
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Build
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-28 08:41 UTC by Dominique Leuenberger
Modified: 2016-11-28 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Dist network-error-symbolic.png (867 bytes, patch)
2016-11-28 12:38 UTC, Michael Catanzaro
none Details | Review
Dist network-error-symbolic.png (867 bytes, patch)
2016-11-28 15:31 UTC, Iulian Radu
none Details | Review

Description Dominique Leuenberger 2016-11-28 08:41:21 UTC
The tarball is missing the file network-error-symbolic.png, which is referenced by the gresources.xml file.

The png exists in git (src/resources)
Comment 1 Michael Catanzaro 2016-11-28 12:29:57 UTC
How
did
it
pass
distcheck
:(
Comment 2 Michael Catanzaro 2016-11-28 12:32:08 UTC
Hm, not only that, I also built it from tarball for the GNOME 3.23.2 release. Don't doubt that it's broken but I wonder why it worked for me....
Comment 3 Michael Catanzaro 2016-11-28 12:38:09 UTC
The following fix has been pushed:
2dbb152 Dist network-error-symbolic.png
Comment 4 Michael Catanzaro 2016-11-28 12:38:12 UTC
Created attachment 340896 [details] [review]
Dist network-error-symbolic.png

I also audited the list to make sure it's the only resource that was
missing from the tarball.
Comment 5 Dominique Leuenberger 2016-11-28 12:39:02 UTC
Just for the  record, to also have an actual build log recorded here:

>[  113s] Making all in src
>[  113s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/epiphany-3.23.2.1/src'
>[  113s]   GEN      epiphany-resources.c
>[  113s]   GEN      epiphany-resources.h
>[  113s]   GEN      stamp-ephy-type-builtins.c
>[  113s]   GEN      stamp-ephy-type-builtins.h
>[  113s] ./resources/epiphany.gresource.xml: Failed to locate ?network-error-symbolic.png? in any source directory.
>[  113s] ./resources/epiphany.gresource.xml: Failed to locate ?network-error-symbolic.png? in any source directory.
>[  113s] make[2]: *** [Makefile:1496: epiphany-resources.c] Error 1
>[  113s] make[2]: *** Waiting for unfinished jobs....
>[  113s] make[2]: *** [Makefile:1499: epiphany-resources.h] Error 1
>[  113s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/epiphany-3.23.2.1/src'
Comment 6 Iulian Radu 2016-11-28 15:31:58 UTC
Created attachment 340918 [details] [review]
Dist network-error-symbolic.png

I also audited the list to make sure it's the only resource that was
missing from the tarball.