After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775041 - vaapidecodebin: bring back dynamic configuration
vaapidecodebin: bring back dynamic configuration
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-24 19:02 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-12-01 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vaapidecodebin: bring back dynamic configuration (8.26 KB, patch)
2016-11-24 19:03 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-11-24 19:02:57 UTC
In commit ca0c3fd6 we remove the dynamic configuration if the bin
because we assumed that the bin will be always static as it is
registered.

Nonetheless we were wrong, because it is possible to request, with a
property, to avoid the use of the post-processor.

Since we want to add a way to disable the post-processor through
environment variables, this remove feature is required again.

If the environment variable GST_VAAPI_DISABLE_VPP is defined the
postprocessor inside of the vaapidecodebin is disabled, then
vaapidecodebin is an alias of the old vaapidecode.
Comment 1 Víctor Manuel Jáquez Leal 2016-11-24 19:03:01 UTC
Created attachment 340706 [details] [review]
vaapidecodebin: bring back dynamic configuration
Comment 2 Víctor Manuel Jáquez Leal 2016-12-01 12:00:51 UTC
Comment on attachment 340706 [details] [review]
vaapidecodebin: bring back dynamic configuration

commit 4609f7fd5e35fef9699578e2e7c104a143a2f896
Author: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Date:   Mon Nov 21 19:29:22 2016 +0100

    vaapidecodebin: bring back dynamic configuration

    In commit ca0c3fd6 we remove the dynamic configuration if the bin
    because we assumed that the bin will be always static as it is
    registered.

    Nonetheless we were wrong, because it is possible to request, with a
    property, to avoid the use of the post-processor.

    Since we want to add a way to disable the post-processor through
    environment variables, this remove feature is required again.

    If the environment variable GST_VAAPI_DISABLE_VPP is defined the
    postprocessor inside of the vaapidecodebin is disabled, then
    vaapidecodebin is an alias of the old vaapidecode.

    https://bugzilla.gnome.org/show_bug.cgi?id=775041