After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774827 - clutter: Fix a couple introspection warnings
clutter: Fix a couple introspection warnings
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-11-22 04:56 UTC by Jonas Ådahl
Modified: 2016-11-23 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clutter: Fix a couple introspection warnings (3.06 KB, patch)
2016-11-22 04:56 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2016-11-22 04:56:09 UTC 
This fixes three warnings printed during introspecting clutter.
Comment 1 Jonas Ådahl 2016-11-22 04:56:15 UTC 
Created attachment 340486 [details] [review]
clutter: Fix a couple introspection warnings

This includes not introspecting ClutterStageView things at all for now,
as they are only used by C code.
Comment 2 Florian Müllner 2016-11-22 12:45:10 UTC 
Review of attachment 340486 [details] [review]:

::: clutter/clutter/clutter-device-manager.c
@@ +457,3 @@
  * Creates a virtual input device.
  *
+ * Return value: (transfer full): a newly created virtual device

To my knowledge, "Return:" and "Return value:" are equally valid - if they weren't, there'd be a lot more comments to fix. Otherwise LGTM
Comment 3 Jonas Ådahl 2016-11-23 14:00:54 UTC 
Pushed after having removed the unnecessary Returns -> Return value change.

Attachment 340486 [details] pushed as c2e7282 - clutter: Fix a couple introspection warnings