After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774747 - qtdemux: compiler warning with gcc 6.2
qtdemux: compiler warning with gcc 6.2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-20 13:52 UTC by christophe vr
Modified: 2016-11-21 07:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Just initialize size with 0. (1.16 KB, patch)
2016-11-20 13:52 UTC, christophe vr 		committed Details | Review

Description christophe vr 2016-11-20 13:52:04 UTC 
Created attachment 340353 [details] [review]
Just initialize size with 0.

With git master there is a compile error with gcc 6.2
Build in cross bitbake enviroment for mipsel32el stb's
Pli5

Host pc ubuntu 16.04 x86_64 target mipsel32el vuduo2 stb.
Compiler gcc/g++ 6.2.

ERROR:

| ../../../git/gst/isomp4/qtdemux.c: In function 'qtdemux_parse_tree':
| ../../../git/gst/isomp4/qtdemux.c:10224:24: error: 'size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
|                  offset += size;
|                         ^~
| ../../../git/gst/isomp4/qtdemux.c:10197:25: note: 'size' was declared here
|                  guint32 size, tag;
|                          ^~~~

It can be easely solved with patch I included here.
Comment 1 Sebastian Dröge (slomo) 2016-11-21 07:33:19 UTC 
commit fc3022da1cb4389b40a978911d9b7faf74c6cdeb
Author: christophecvr <stefansat@telenet.be>
Date:   Sun Nov 20 14:12:16 2016 +0100

    qtdemux: Fix wrong compiler warning with gcc 6.2
    
    | ../../../git/gst/isomp4/qtdemux.c: In function 'qtdemux_parse_tree':
    | ../../../git/gst/isomp4/qtdemux.c:10224:24: error: 'size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    |                  offset += size;
    |                         ^~
    | ../../../git/gst/isomp4/qtdemux.c:10197:25: note: 'size' was declared here
    |                  guint32 size, tag;
    |                          ^~~~
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774747