GNOME Bugzilla – Bug 774623
basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed
Last modified: 2016-11-18 10:39:40 UTC
See commit message
Created attachment 340135 [details] [review] basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed It might've failed just because of flushing or other things, and we should retry again on the next possibility if something ever calls in here again.
Should probably double-check all other places where we make use of the RECONFIGURE flag.
Created attachment 340156 [details] [review] rtpbasepayload: Ensure to set the RECONFIGURE flag again if reconfiguration failed
Created attachment 340157 [details] [review] dvdec: Fix handling of negotiation failures Return NOT_NEGOTIATED if sending the caps event fails, or FLUSHING if the pad was flushing at that point.
Created attachment 340158 [details] [review] deinterlace: Mark pad as needing reconfiguration again if reconfiguration failed And consider negotiation failures on flushing pads as FLUSHING, not as NOT_NEGOTIATED.
Created attachment 340159 [details] [review] monoscope: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340160 [details] [review] rtpmux: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340162 [details] [review] textoverlay: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340163 [details] [review] assrender: Mark pad as needing reconfiguration again if reconfiguration failed Also return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340164 [details] [review] ttmlrender: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340165 [details] [review] videoaggregator: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340166 [details] [review] vtdec: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Created attachment 340167 [details] [review] vc1parse: Mark pad as needing reconfiguration again if it failed And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment on attachment 340135 [details] [review] basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed Attachment 340135 [details] pushed as f08c8d2 - basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed
Attachment 340156 [details] pushed as b9f59fd - rtpbasepayload: Ensure to set the RECONFIGURE flag again if reconfiguration failed Attachment 340162 [details] pushed as d34e326 - textoverlay: Mark pad as needing reconfiguration again if it failed
Attachment 340157 [details] pushed as f32603b - dvdec: Fix handling of negotiation failures Attachment 340158 [details] pushed as 858d9f9 - deinterlace: Mark pad as needing reconfiguration again if reconfiguration failed Attachment 340159 [details] pushed as a9b1aa1 - monoscope: Mark pad as needing reconfiguration again if it failed Attachment 340160 [details] pushed as 15630db - rtpmux: Mark pad as needing reconfiguration again if it failed
Attachment 340163 [details] pushed as b2dd97a - assrender: Mark pad as needing reconfiguration again if reconfiguration failed Attachment 340164 [details] pushed as a1dc37b - ttmlrender: Mark pad as needing reconfiguration again if it failed Attachment 340165 [details] pushed as db504c9 - videoaggregator: Mark pad as needing reconfiguration again if it failed Attachment 340166 [details] pushed as 279fb3d - vtdec: Mark pad as needing reconfiguration again if it failed Attachment 340167 [details] pushed as 0f657ce - vc1parse: Mark pad as needing reconfiguration again if it failed