After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774454 - playbin3: remove dead code
playbin3: remove dead code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-15 06:28 UTC by Wonchul Lee
Modified: 2016-11-15 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin3: remove dead code (1.26 KB, patch)
2016-11-15 06:30 UTC, Wonchul Lee 		none Details | Review

Description Wonchul Lee 2016-11-15 06:28:38 UTC 
"sync-streams" and etc properties settings are in the dead code path and It seems like the input-selector element no longer used in playbin3 as default.
Comment 1 Wonchul Lee 2016-11-15 06:30:57 UTC 
Created attachment 339893 [details] [review]
playbin3: remove dead code
Comment 2 Jan Schmidt 2016-11-15 13:33:35 UTC 
Thanks, pushed:

commit 08ee940de2244f192f8ba108a2efb2aef7ac6bc2
Author: Wonchul Lee <wonchul.lee@collabora.com>
Date:   Tue Nov 15 15:23:20 2016 +0900

    playbin3: remove dead code
    
    It never reach into this code path, custom_combiner always not null
    here.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774454