After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774439 - warning: 'GOFFICE_WITH_LONG_DOUBLE' is not defined, evaluates to 0
warning: 'GOFFICE_WITH_LONG_DOUBLE' is not defined, evaluates to 0
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
GIT
Other Mac OS
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2016-11-14 22:57 UTC by Ludovic Rousseau
Modified: 2016-11-16 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ludovic Rousseau 2016-11-14 22:57:53 UTC 
The grisbi software uses goffice.
On macOS (10.12.1) I have the following warning:

/usr/local/Cellar/goffice/0.10.32/include/libgoffice-0.10/goffice/utils/go-libxml-extras.h:50:5: warning: 
      'GOFFICE_WITH_LONG_DOUBLE' is not defined, evaluates to 0 [-Wundef]
#if GOFFICE_WITH_LONG_DOUBLE
    ^

My problem is that I use the -Werror compiler option (to do some QA) so any warning is treated as an error and the build of grisbi fails because of goffice.

The fix is quite obvious: replace "#if" by "#ifdef"

I have checked the code at https://github.com/GNOME/goffice/blob/master/goffice/utils/go-libxml-extras.h#L50 and the bug is still present.
Comment 1 Jean Bréfort 2016-11-16 08:05:49 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.

Thanks for reporting and for the fix.