GNOME Bugzilla – Bug 774357
mpdparser: Support multiple Period elements in external xml
Last modified: 2016-11-14 14:57:30 UTC
mpdparser: Support multiple Period elements in external xml External xml could have empty, one or multiple top-level "Period" elements. Because xml parser cannot parse the multiple top-level elements (i.e., no root element), we need to wrap a xml in order to make root element. See also ISO/IEC 23009-1:2014 5.3.2.2
Created attachment 339750 [details] [review] mpdparser: Support multiple Period elements in external xml
This patch is to fix following mpd parsing error. http://dash.akamaized.net/dash264/TestCases/5b/nomor/8.mpd http://dash.akamaized.net/dash264/TestCases/5b/nomor/9.mpd http://dash.akamaized.net/dash264/TestCases/5b/nomor/10.mpd http://dash.akamaized.net/dash264/TestCases/5b/nomor/11.mpd
Created attachment 339772 [details] [review] mpdparser: Support multiple Period elements in external xml
Review of attachment 339772 [details] [review]: Please also add a unit test for this to the mpdparser tests. Looks good otherwise, thanks :)
(In reply to Sebastian Dröge (slomo) from comment #4) > Review of attachment 339772 [details] [review] [review]: > > Please also add a unit test for this to the mpdparser tests. Looks good > otherwise, thanks :) I'll prepare it :)
Created attachment 339804 [details] [review] mpdparser: Support multiple Period elements in external xml Updating patch with test code.
Created attachment 339805 [details] [review] mpdparser: Support multiple Period elements in external xml
Created attachment 339807 [details] [review] mpdparser: Support multiple Period elements in external xml delete unintended diff. (due to removed whitespace)
Review of attachment 339807 [details] [review]: Looks good, thanks
Attachment 339807 [details] pushed as 68e4f91 - mpdparser: Support multiple Period elements in external xml