After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774199 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-10 12:21 UTC by Piotr Drąg
Modified: 2016-11-12 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use Unicode in translatable strings (15.65 KB, patch)
2016-11-10 12:21 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2016-11-10 12:21:11 UTC 
Created attachment 339473 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Juan R. Garcia Blanco 2016-11-12 08:46:50 UTC 
Thank you very much. I cannot apply it right now because I don't know what state in the release cycle we are in (I've seen in other components, it is marked as commit after unfreeze...). I will take care of it asap. Thanks!
Comment 2 Piotr Drąg 2016-11-12 10:32:34 UTC 
GNOME is in the development stage, but gnome-dictionary lacks the stable gnome-3-20 branch (there was no 3.22 release). You should branch it either after the 3.20 release commit (i.e. commit 95a70dc), or before the first unstable commit (i.e. *before* commit 45ef1b4).

https://wiki.gnome.org/TranslationProject/HandlingStringFreezes
Comment 3 Juan R. Garcia Blanco 2016-11-12 10:45:16 UTC 
Review of attachment 339473 [details] [review]:

Please commit it.
Comment 4 Piotr Drąg 2016-11-12 11:07:57 UTC 
I will commit it as soon as a stable branch is created, to avoid breaking the string freeze.
Comment 5 Juan R. Garcia Blanco 2016-11-12 11:48:12 UTC 
Done. Thank you very much for your support.
Comment 6 Piotr Drąg 2016-11-12 11:50:07 UTC 
Comment on attachment 339473 [details] [review]
Use Unicode in translatable strings

Pushed, thank you for a quick review!