After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774131 - flvmux: Add metadatacreator property
flvmux: Add metadatacreator property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-09 07:11 UTC by Sean-Der
Modified: 2016-11-10 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against git master (4.27 KB, patch)
2016-11-09 07:11 UTC, Sean-Der 		reviewed Details | Review
Patch against git master from slomo review (4.37 KB, patch)
2016-11-10 04:04 UTC, Sean-Der 		committed Details | Review

Description Sean-Der 2016-11-09 07:11:02 UTC 
Allow users to set the value of metadatacreator.

Currently I use this to identity what process created a file.

If this patch is not acceptable would I be able to expand the tags accepted, right now only artist/title seem to be supported.
Comment 1 Sean-Der 2016-11-09 07:11:22 UTC 
Created attachment 339365 [details] [review]
Patch against git master
Comment 2 Sebastian Dröge (slomo) 2016-11-09 07:34:39 UTC 
Comment on attachment 339365 [details] [review]
Patch against git master

Seems fine to me, it's basically like the "writing-app" property in matroskamux. You probably want to include the version in the default string though.

Also in the NULL case in set_property(), it should be better to reset it to the default again
Comment 3 Sean-Der 2016-11-10 04:04:04 UTC 
Hi Slomo!

Thank you so much for the quick review, probably the fastest turnaround I have ever seen in Free Software.

The attached patch resets to the default case in the NULL case, and includes the PACKAGE_VERSION in the default.
Comment 4 Sean-Der 2016-11-10 04:04:35 UTC 
Created attachment 339421 [details] [review]
Patch against git master from slomo review
Comment 5 Sebastian Dröge (slomo) 2016-11-10 11:11:52 UTC 
commit 2f707370d48b3f5034dd1ab85202cbf533b3f4b4
Author: Sean DuBois <sean@siobud.com>
Date:   Wed Nov 9 06:25:27 2016 +0000

    flvmux: Add metadatacreator property
    
    Allow users to set metadatacreator value in the meta packet
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774131