After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774009 - Invalid annotations for some methods
Invalid annotations for some methods
Status: RESOLVED DUPLICATE of bug 781234
Product: glib
Classification: Platform
Component: introspection
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-11-06 16:17 UTC by Marcin Kolny (IRC: loganek)
Modified: 2018-02-09 11:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (4.62 KB, patch)
2016-11-06 16:18 UTC, Marcin Kolny (IRC: loganek) 		needs-work Details | Review

Description Marcin Kolny (IRC: loganek) 2016-11-06 16:17:31 UTC 
I've noticed that some method parameters miss (out caller-allocates) annotation.
Please review my patch, and if is ok, I'll push it.
Comment 1 Marcin Kolny (IRC: loganek) 2016-11-06 16:18:21 UTC 
Created attachment 339199 [details] [review]
fix
Comment 2 Daniel Boles 2017-09-06 20:49:48 UTC 
Review of attachment 339199 [details] [review]:

Everything else looks obviously correct, but...

::: gio/ginetaddress.c
@@ +507,3 @@
 /**
  * g_inet_address_new_from_bytes:
+ * @bytes: (array) (out caller-allocates) (element-type guint8): raw address data

This is wrong; @bytes is an input parameter and points to const data.
Comment 3 Philip Withnall 2018-02-09 11:20:52 UTC 
Review of attachment 339199 [details] [review]:

This is going to run into the same problems as bug #781234. I’ll dupe this to that bug for now, and we can either fix all of these annotations, or none of them, depending on what Rico says.
Comment 4 Philip Withnall 2018-02-09 11:21:09 UTC 

*** This bug has been marked as a duplicate of bug 781234 ***