After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773884 - show previous/next button for media controls only if there is one.
show previous/next button for media controls only if there is one.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 778817 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-03 11:06 UTC by Mohammed Sadiq
Modified: 2017-03-01 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpris: Hide forward/backward controls when unavailable (3.24 KB, patch)
2016-11-03 17:43 UTC, Florian Müllner 		accepted-commit_now Details | Review
mpris: Make forward/backward insensitive when unavailable (4.13 KB, patch)
2017-02-27 21:34 UTC, Florian Müllner 		committed Details | Review

Description Mohammed Sadiq 2016-11-03 11:06:55 UTC 
The media controls in notification always show previous/next buttons irrespective of whether it's possible or not. It would be nice if these buttons are shown only if there is some previous/next item to play, or else fading out those buttons
Comment 1 Florian Müllner 2016-11-03 17:43:25 UTC 
Created attachment 339057 [details] [review]
mpris: Hide forward/backward controls when unavailable

Media notifications currently always show the forward and backward
buttons, regardless of whether the corresponding action is available
or not. While this is consistent with most media players, we don't
have the concept of insensitive controls in notifications, so hide
them completely when the corresponding action is not available.
Comment 2 Allan Day 2016-11-11 12:45:32 UTC 
Making the button insensitive would be better than hiding it, but hiding seems OK.
Comment 3 Florian Müllner 2017-02-17 10:53:25 UTC 
*** Bug 778817 has been marked as a duplicate of this bug. ***
Comment 4 Rui Matos 2017-02-19 19:18:40 UTC 
Review of attachment 339057 [details] [review]:

lgtm
Comment 5 Florian Müllner 2017-02-27 21:34:03 UTC 
Created attachment 346869 [details] [review]
mpris: Make forward/backward insensitive when unavailable

With the style changes in bug 775763 (namely removing the background in normal state), making unavailable controls insensitive works quite well in my opinion. So here's the preferred alternative to hiding ...
Comment 6 Rui Matos 2017-02-28 15:15:02 UTC 
Review of attachment 346869 [details] [review]:

sure
Comment 7 Florian Müllner 2017-03-01 10:01:55 UTC 
Attachment 346869 [details] pushed as 1981652 - mpris: Make forward/backward insensitive when unavailable