After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773846 - [PATCH] hostname-helper: use SSID_MAX_LEN
[PATCH] hostname-helper: use SSID_MAX_LEN
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-02 17:10 UTC by Lubomir Rintel
Modified: 2017-01-19 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] hostname-helper: use SSID_MAX_LEN (862 bytes, patch)
2016-11-02 17:10 UTC, Lubomir Rintel 		accepted-commit_now Details | Review

Description Lubomir Rintel 2016-11-02 17:10:52 UTC 
Created attachment 338971 [details] [review]
[PATCH] hostname-helper: use SSID_MAX_LEN

It looks a bit weird to define it and still use the numeric literal.
Comment 1 Rui Matos 2016-11-29 17:59:26 UTC 
Review of attachment 338971 [details] [review]:

there's another literal 32 in an assert a few lines up, please replace that as well before pushing
Comment 2 Lubomir Rintel 2017-01-19 09:49:03 UTC 
da4a591b4d9623853c21f24a45a00761ec4749bd