After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773711 - Totem crashes with SIGBUS, when network status is toggled.
Totem crashes with SIGBUS, when network status is toggled.
Status: RESOLVED OBSOLETE
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-31 07:18 UTC by gnome.vrb
Modified: 2018-09-24 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon-helpers: GFile is owned by GFileIcon. Do not unref it. (763 bytes, patch)
2016-12-03 09:20 UTC, gnome.vrb 		committed Details | Review
core: Check for source deletion after emitting SIG_SOURCE_ADDED signal (2.62 KB, patch)
2016-12-03 19:48 UTC, gnome.vrb 		none Details | Review
core: Check for source deletion after emitting SIG_SOURCE_ADDED signal (2.85 KB, patch)
2016-12-03 20:38 UTC, gnome.vrb 		none Details | Review

Description gnome.vrb 2016-10-31 07:18:45 UTC 



+
Trace
    236784






    

  • 
#0
g_file_get_uri

    
                at ././gio/gfile.c
                  line
                  553

    

    • 

  • 
#1
totem_grilo_get_thumbnail

    
                at icon-helpers.c
                  line
                  314

    

    • 

  • 
#2
update_search_thumbnails_idle

    
                at totem-grilo.c
                  line
                  444

    

    • 

  • 
#3
update_search_thumbnails_idle

    
                at totem-grilo.c
                  line
                  502

    

    • 

  • 
#4
g_main_context_dispatch

    
                at ././glib/gmain.c
                  line
                  3203

    

    • 

  • 
#5
g_main_context_dispatch

    
                at ././glib/gmain.c
                  line
                  3856

    

    • 

  • 
#6
g_main_context_iterate

    
                at ././glib/gmain.c
                  line
                  3929

    

    • 

  • 
#7
g_main_context_iteration

    
                at ././glib/gmain.c
                  line
                  3990

    

    • 

  • 
#8
g_application_run

    
                at ././gio/gapplication.c
                  line
                  2381

    

    • 

  • 
#9
main

    • 













Comment 1


gnome.vrb





          2016-10-31 07:21:01 UTC
        



Steps to reproduce:
-------------------

1. Open totem and select 'Channels' tab.
2. Go to 'System Settings -> Network -> Wired' and toggle ON state to OFF, and back to ON.
3. Totem crashes.






Comment 2


gnome.vrb





          2016-12-03 09:20:05 UTC
        



Created attachment 341300 [details] [review]
icon-helpers: GFile is owned by GFileIcon. Do not unref it.






Comment 3


gnome.vrb





          2016-12-03 19:14:31 UTC
        



Ran into another crash after the above fix.





+
Trace
    236913






    

  • 
#0
__strcmp_sse2_unaligned

    
                at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S
                  line
                  32

    

    • 

  • 
#1
g_str_equal

    
                at ././glib/ghash.c
                  line
                  1846

    

    • 

  • 
#2
g_strv_contains

    
                at ././glib/gstrfuncs.c
                  line
                  3162

    

    • 

  • 
#3
network_changed_cb

    
                at grl-registry.c
                  line
                  279

    

    • 

  • 
#7
<emit signal notify:connectivity on instance 0x555aa1aa7890 [GNetworkMonitorNM]>

    
                at ././gobject/gsignal.c
                  line
                  3447

    

    • 

  • 
#8
g_object_dispatch_properties_changed

    
                at ././gobject/gobject.c
                  line
                  1064

    

    • 

  • 
#9
g_object_notify

    
                at ././gobject/gobject.c
                  line
                  1157

    

    • 

  • 
#10
g_object_notify

    
                at ././gobject/gobject.c
                  line
                  1205

    

    • 

  • 
#11
sync_properties

    
                at ././gio/gnetworkmonitornm.c
                  line
                  213

    

    • 

  • 
#12
proxy_signal_cb

    
                at ././gio/gnetworkmonitornm.c
                  line
                  258

    

    • 

  • 
#13
ffi_call_unix64

    
                at ../src/x86/unix64.S
                  line
                  76

    

    • 

  • 
#14
ffi_call

    
                at ../src/x86/ffi64.c
                  line
                  525

    

    • 

  • 
#19
<emit signal ??? on instance 0x555aa1944140 [GDBusProxy]>

    
                at ././gobject/gsignal.c
                  line
                  3447

    

    • 

  • 
#20
on_signal_received

    
                at ././gio/gdbusproxy.c
                  line
                  917

    

    • 

  • 
#21
emit_signal_instance_in_idle_cb

    
                at ././gio/gdbusconnection.c
                  line
                  3705

    

    • 

  • 
#22
g_main_context_dispatch

    
                at ././glib/gmain.c
                  line
                  3203

    

    • 

  • 
#23
g_main_context_dispatch

    
                at ././glib/gmain.c
                  line
                  3856

    

    • 

  • 
#24
g_main_context_iterate

    
                at ././glib/gmain.c
                  line
                  3929

    

    • 

  • 
#25
g_main_context_iteration

    
                at ././glib/gmain.c
                  line
                  3990

    

    • 

  • 
#26
g_application_run

    
                at ././gio/gapplication.c
                  line
                  2381

    

    • 

  • 
#27
main

    
                at totem.c
                  line
                  83

    

    • 













Comment 4


gnome.vrb





          2016-12-03 19:48:48 UTC
        



Created attachment 341328 [details] [review]
core: Check for source deletion after emitting SIG_SOURCE_ADDED signal

grl_source_get_id (source) cannot be used as a key to the hash, as the source might have already been deleted. Hence the minor refactor around grl_source_get_id.






Comment 5


gnome.vrb





          2016-12-03 20:38:58 UTC
        



Created attachment 341329 [details] [review]
core: Check for source deletion after emitting SIG_SOURCE_ADDED signal

Duplicate source_id and use it.






Comment 6


Bastien Nocera





          2016-12-05 11:31:00 UTC
        



Comment on attachment 341300 [details] [review]
icon-helpers: GFile is owned by GFileIcon. Do not unref it.

The commit subject and logs could do with some work. Thanks for the patch though!






Comment 7


gnome.vrb





          2016-12-05 16:55:05 UTC
        



(In reply to vrishab from comment #5)
> Created attachment 341329 [details] [review] [review]
> core: Check for source deletion after emitting SIG_SOURCE_ADDED signal
> 
> Duplicate source_id and use it.

Probably, a better way would be to allow the apps to convey the "supported_media" during registry initialization. That way, the registry can ignore loading unsupported plugins. I don't see a point in registering and unregistering sources for unsupported media.

Thoughts ?






Comment 8


Bastien Nocera





          2016-12-05 16:58:13 UTC
        



No, because that still wouldn't cover all possible use cases.






Comment 9


GNOME Infrastructure Team





          2018-09-24 09:49:52 UTC
        



-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/104.