After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773514 - rtph263pay: Use GST_TRACE for logging bitsream parsing
rtph263pay: Use GST_TRACE for logging bitsream parsing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 773512
Blocks:
 
 
Reported: 2016-10-26 07:58 UTC by Stian Selnes (stianse)
Modified: 2016-11-01 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtph263pay: Use GST_TRACE for logging bitsream parsing (10.88 KB, patch)
2016-10-26 07:58 UTC, Stian Selnes (stianse) 		committed Details | Review
rtph263pay: Use GST_DEBUG_OBJECT etc instead of GST_DEBUG (34.81 KB, patch)
2016-10-26 14:47 UTC, Stian Selnes (stianse) 		committed Details | Review
rtph263pay: Fix indentation (21.95 KB, patch)
2016-10-26 14:47 UTC, Stian Selnes (stianse) 		committed Details | Review

Description Stian Selnes (stianse) 2016-10-26 07:58:53 UTC 
Bump the bitstream parsing to TRACE log level so it doesn't flood the
output when trying to read the more useful DEBUG and LOG messages.
Comment 1 Stian Selnes (stianse) 2016-10-26 07:58:58 UTC 
Created attachment 338479 [details] [review]
rtph263pay: Use GST_TRACE for logging bitsream parsing
Comment 2 Stian Selnes (stianse) 2016-10-26 08:01:52 UTC 
Dependency added in order to have the patch apply cleanly.
Comment 3 Sebastian Dröge (slomo) 2016-10-26 08:06:10 UTC 
Comment on attachment 338479 [details] [review]
rtph263pay: Use GST_TRACE for logging bitsream parsing

Bonus points for making it GST_TRACE_OBJECT :)
Comment 4 Stian Selnes (stianse) 2016-10-26 14:47:24 UTC 
Created attachment 338528 [details] [review]
rtph263pay: Use GST_DEBUG_OBJECT etc instead of GST_DEBUG
Comment 5 Stian Selnes (stianse) 2016-10-26 14:47:29 UTC 
Created attachment 338529 [details] [review]
rtph263pay: Fix indentation
Comment 6 Stian Selnes (stianse) 2016-10-26 14:49:21 UTC 
I need to think carefully about what to use all these bonus points for :-)

I've split the cleanup in different patches to more easily see what they do.
Comment 7 Sebastian Dröge (slomo) 2016-11-01 18:20:14 UTC 
commit fca2d2f9f0313f57a0c4c70f2ef9324ffc693895
Author: Stian Selnes <stian@pexip.com>
Date:   Wed Oct 26 16:42:19 2016 +0200

    rtph263pay: Fix indentation
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773514

commit 087ae641231e567773530dfb169d34b0078b8829
Author: Stian Selnes <stian@pexip.com>
Date:   Tue Oct 18 11:35:58 2016 +0200

    rtph263pay: Use GST_TRACE_OBJECT for logging bitstream parsing
    
    Bump the bitstream parsing to TRACE log level so it doesn't flood the
    output when trying to read the more useful DEBUG and LOG messages.
    
    Also use GST_DEBUG_OBJECT instead of GST_DEBUG in various places
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773514