After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773265 - late background changing after suspend/resume
late background changing after suspend/resume
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 739830 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-10-20 10:25 UTC by Fabian Greffrath
Modified: 2017-10-07 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: Update animations when coming back from suspend (2.13 KB, patch)
2016-10-21 13:03 UTC, Florian Müllner 		committed Details | Review

Description Fabian Greffrath 2016-10-20 10:25:36 UTC 
Hi there,

when I do work in the evening, the default GNOME background wallpaper is in its dark-themed mode which fits the evening daytime. When I close the lid to suspend the system and open it up again in the morning to resume, the background is still in its dark-themed mode for a rather long time frame (about a minute or so) until it abruptly switches into its light-themed mode which fits the morning daytime.

I suggest to run the code which checks the daytime to decide about the background theme immediately after resume (or in much shorter cycles of about one second).

Thanks,

Fabian
Comment 1 Bastien Nocera 2016-10-20 12:49:19 UTC 
Reassigning to gnome-shell, that handles the display of the lock screen background.
Comment 2 Fabian Greffrath 2016-10-21 11:47:36 UTC 
I was talking about the regular GNOME desktop background (the one that comes with gnome-backgrounds and changes with daytime), not the lock screen background.
Comment 3 Florian Müllner 2016-10-21 13:03:34 UTC 
Created attachment 338188 [details] [review]
background: Update animations when coming back from suspend

We currently reload animated backgrounds on timezone changes, but
there are other cases where the time can change unexpectedly and
the background no longer matches the time of day. One case we can
easily handle is when coming back from suspend, so do that.

Note that I did not actually test the patch - the code may run before the clock is updated and we end up with the same slice that was used when suspending ...
Comment 4 Rui Matos 2016-10-21 16:34:00 UTC 
Review of attachment 338188 [details] [review]:

lgtm, untested
Comment 5 Florian Müllner 2016-10-30 21:41:35 UTC 
Attachment 338188 [details] pushed as ccacb5f - background: Update animations when coming back from suspend
Comment 6 Florian Müllner 2017-10-07 17:50:33 UTC 
*** Bug 739830 has been marked as a duplicate of this bug. ***