After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773103 - videodecoder: Default caps sets format I420
videodecoder: Default caps sets format I420
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.10.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-17 13:56 UTC by Stian Selnes (stianse)
Modified: 2016-10-31 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videodecoder: Default caps sets format I420 (5.56 KB, patch)
2016-10-17 13:56 UTC, Stian Selnes (stianse) 		committed Details | Review

Description Stian Selnes (stianse) 2016-10-17 13:56:54 UTC 
Also the format must be fixed on the default raw caps. If not
gst_video_info_from_caps() will fail and
gst_video_decoder_negotiate_default_caps() return FALSE.

The test simulates the use case where a gap event is received before
the first buffer causing the decoder to fall back to the default caps.
Comment 1 Stian Selnes (stianse) 2016-10-17 13:56:58 UTC 
Created attachment 337854 [details] [review]
videodecoder: Default caps sets format I420
Comment 2 Nicolas Dufresne (ndufresne) 2016-10-17 14:21:46 UTC 
Review of attachment 337854 [details] [review]:

That make no sense, I420 could not even exist in the template caps.
Comment 3 gstreamer 2016-10-17 15:25:16 UTC 
That is taken care of by using fixate on the allowed caps. So if, for instance, template or downstream only allows NV12, NV12 will be chosen. I420 will only be set if no format is specified in the allowed caps, or if multiple formats including I420 is allowed.
Comment 4 Stian Selnes (stianse) 2016-10-17 15:27:26 UTC 
Ooops, submitted previous comments with wrong account. It was me... :-)
Comment 5 Sebastian Dröge (slomo) 2016-10-20 11:12:02 UTC 
Attachment 337854 [details] pushed as 92392a4 - videodecoder: Default caps sets format I420