After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772935 - can't save attachments
can't save attachments
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: attachments
master
Other Linux
: Normal major
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-14 14:05 UTC by Adam Dingle
Modified: 2016-10-18 05:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reorder correctly the labels of Gtk.FileChooserNative (1.70 KB, patch)
2016-10-17 10:09 UTC, Jiri Cerny 		committed Details | Review

Description Adam Dingle 2016-10-14 14:05:13 UTC 
With recent changes in master, saving attachments no longer works:

1. Select an attachment and click the "Save selected attachments" button.
2. Geary will prompt for a filename and location.  Accept the defaults and click Save.
3. The file is not saved in the target location.
Comment 1 Michael Gratton 2016-10-15 01:57:54 UTC 
Hey Adam, are you sure? I just tried it then and it seemed to work fine. The issue might be that the original attachment's mtime/ctime is retained, rather than when it was saved.
Comment 2 Adam Dingle 2016-10-15 14:45:54 UTC 
This is absolutely not working for me.

However, perhaps my Geary setup is in a bad state because I attempted to remove all Geary state by deleting the .local/share/geary directory.  As I explained in a recent mailing list message, this used to be an easy way to reset Geary back to its initial state.  In master, however, Geary seems to retain some knowledge of accounts even after that directory is deleted.

So perhaps that explains the problem.  Is there some way I can get back to a clean state so I can test whether this problem still occurs in that situation?
Comment 3 Adam Dingle 2016-10-15 15:24:13 UTC 
OK - I got some helpful feedback on the mailing list about how to restore Geary to a clean state.  I did that.  Unfortunately this bug is still occurring for me.
Comment 4 Adam Dingle 2016-10-16 18:16:40 UTC 
I debugged a bit.  It turns out that when I press Save in the filename selection dialog, dialog.run() returns Gtk.ResponseType.CANCEL and so the attachment is not saved.  If I press Cancel in the dialog, dialog.run() returns Gtk.ResponseType.ACCEPT and the attachment is saved!

At least I have a workaround now.  :)
Comment 5 Adam Dingle 2016-10-16 18:17:47 UTC 
By the way I'm running Ubuntu 16.10, which has GTK 3.20.9.
Comment 6 Jiri Cerny 2016-10-17 10:09:38 UTC 
Created attachment 337823 [details] [review]
Reorder correctly the labels of Gtk.FileChooserNative

Fixes bug
Comment 7 Michael Gratton 2016-10-17 11:21:26 UTC 
Review of attachment 337823 [details] [review]:

Hi Jiri, thanks for the patch. This looks good to me - after applying it it sill works for me.

Adam, can you try applying this and see if it fixes the issue for you?
Comment 8 Adam Dingle 2016-10-17 13:51:54 UTC 
I tried the patch.  Works perfectly for me!
Comment 9 Michael Gratton 2016-10-17 13:55:26 UTC 
Review of attachment 337823 [details] [review]:

Patch pushed to master as commit 199a39d. Thanks for the patch and testing, guys!