After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772644 - Fix level test in CK_FORK=no mode
Fix level test in CK_FORK=no mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.10.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 766561
Blocks:
 
 
Reported: 2016-10-09 13:54 UTC by Jan Alexander Steffens (heftig)
Modified: 2016-10-31 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.98 KB, patch)
2016-10-09 13:54 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2016-10-09 13:54:58 UTC 
Created attachment 337268 [details] [review]
patch

The tests accumulate buffers in GstCheck's buffers list, and the list is
not (consistently) reset between tests. Do that and remove the now
conflicting unrefs for outbuffers.
Comment 1 Sebastian Dröge (slomo) 2016-10-09 14:05:52 UTC 
Review of attachment 337268 [details] [review]:

::: tests/check/elements/level.c
@@ -195,3 @@
   ASSERT_OBJECT_REFCOUNT (bus, "bus", 1);
   gst_object_unref (bus);
-  gst_buffer_unref (outbuffer);

Why do you not unref it anymore? Isn't it leaked now? (Also in the other places)
Comment 2 Jan Alexander Steffens (heftig) 2016-10-09 15:15:16 UTC 
gst_check_drop_buffers unrefs all buffers in the global `buffers` list.
Comment 3 Sebastian Dröge (slomo) 2016-10-20 10:24:10 UTC 
commit 22ced681af8a27bce0ce59a9db68c902e916390b
Author: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date:   Sun Oct 9 15:23:51 2016 +0200

    tests: Fix level test in CK_FORK=no mode
    
    The tests accumulate buffers in GstCheck's buffers list, and the list is
    not (consistently) reset between tests. Do that and remove the now
    conflicting unrefs for outbuffers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772644