Created attachment 337209 [details] [review]
gnome-shell-extension-tool: Add a reload option

Review of attachment 337209 [details] [review]:

::: src/gnome-shell-extension-tool.in
@@ +182,3 @@
+        sys.exit(1)
+
+    bus = dbus.SessionBus()

Should we use GDBus instead of python's own dbus module?

Created attachment 337248 [details] [review]
gnome-shell-extension-tool: Add a reload option

This might be a good fit for extension developers: With
this option one doesn't need to restart the whole Shell
in order to see their changes in effect.

(In reply to Florian Müllner from comment #2)
> Review of attachment 337209 [details] [review] [review]:
> 
> ::: src/gnome-shell-extension-tool.in
> @@ +182,3 @@
> +        sys.exit(1)
> +
> +    bus = dbus.SessionBus()
> 
> Should we use GDBus instead of python's own dbus module?

I don't have a strong opinion here. *I* prefer python's due to its simplicity.

That said, I've attached a patch which uses GDBus via GI.

(In reply to Jonh Wendell from comment #4)
> (In reply to Florian Müllner from comment #2)
> > Review of attachment 337209 [details] [review] [review] [review]:
> > 
> > ::: src/gnome-shell-extension-tool.in
> > @@ +182,3 @@
> > +        sys.exit(1)
> > +
> > +    bus = dbus.SessionBus()
> > 
> > Should we use GDBus instead of python's own dbus module?
> 
> I don't have a strong opinion here. *I* prefer python's due to its
> simplicity.

It might not be available, whereas if you manage to get GTK+ running with Python, then you pretty much have to have gio's GI bindings installed.

> That said, I've attached a patch which uses GDBus via GI.

Review of attachment 337248 [details] [review]:

LGTM. I don't have a strong opinion, but I slightly prefer this one - the Gio typelib is already a dependency, python's own dbus module is not ...

Attachment 337248 [details] pushed as 2812afe - gnome-shell-extension-tool: Add a reload option