After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772562 - main: Don't set locale information again
main: Don't set locale information again
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-07 11:37 UTC by Bastien Nocera
Modified: 2016-10-10 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Don't set locale information again (986 bytes, patch)
2016-10-07 11:37 UTC, Bastien Nocera 		none Details | Review
main: Don't set locale information again (1.35 KB, patch)
2016-10-07 11:38 UTC, Bastien Nocera 		none Details | Review
main: Don't set locale information again (1.35 KB, patch)
2016-10-07 12:15 UTC, Bastien Nocera 		none Details | Review
main: Don't set locale information again (1.38 KB, patch)
2016-10-10 13:26 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-10-07 11:37:32 UTC 
.
Comment 1 Bastien Nocera 2016-10-07 11:37:36 UTC 
Created attachment 337156 [details] [review]
main: Don't set locale information again

It is already done in the wrapper script, and needs to stay there.

See https://bugzilla.gnome.org/show_bug.cgi?id=756324
Comment 2 Bastien Nocera 2016-10-07 11:38:57 UTC 
Created attachment 337157 [details] [review]
main: Don't set locale information again

It is already done in the wrapper script, and needs to stay there.

See https://bugzilla.gnome.org/show_bug.cgi?id=756324
See https://bugzilla.gnome.org/show_bug.cgi?id=766176
Comment 3 Bastien Nocera 2016-10-07 12:15:01 UTC 
Created attachment 337161 [details] [review]
main: Don't set locale information again

It is already done in the wrapper script, and needs to stay there.

See https://bugzilla.gnome.org/show_bug.cgi?id=756324
See https://bugzilla.gnome.org/show_bug.cgi?id=766176
Comment 4 Ray Strode [halfline] 2016-10-10 13:21:59 UTC 
Review of attachment 337161 [details] [review]:

++
Comment 5 Ray Strode [halfline] 2016-10-10 13:22:33 UTC 
Review of attachment 337161 [details] [review]:

::: gnome-session/main.c
@@ +378,3 @@
         }
 
         /* Push locale variables to dbus-daemon */

might want to drop this comment too
Comment 6 Bastien Nocera 2016-10-10 13:26:13 UTC 
Created attachment 337309 [details] [review]
main: Don't set locale information again

It is already done in the wrapper script, and needs to stay there.

See https://bugzilla.gnome.org/show_bug.cgi?id=756324
See https://bugzilla.gnome.org/show_bug.cgi?id=766176
Comment 7 Bastien Nocera 2016-10-10 13:31:54 UTC 
Attachment 337309 [details] pushed as 96968bd - main: Don't set locale information again