GNOME Bugzilla – Bug 772503
gsttimidity: add support for timidity-0.2.x
Last modified: 2016-10-31 10:51:54 UTC
mid_istream_open_mem() doesn't accept autofree argument anymore. Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Created attachment 337046 [details] [review] gsttimidity: add support for timidity-0.2.x
Honestly, I didn't try to compile it... But should work I hope.
Comment on attachment 337046 [details] [review] gsttimidity: add support for timidity-0.2.x Seems good but needs someone to test it. Debian does not ship a library for timidity (and the timidity package has version 2.13, so a completely different scheme). Needs someone to confirm that it actually works.
(In reply to Sebastian Dröge (slomo) from comment #3) > Comment on attachment 337046 [details] [review] [review] > gsttimidity: add support for timidity-0.2.x > > Seems good but needs someone to test it. Debian does not ship a library for > timidity (and the timidity package has version 2.13, so a completely > different scheme). > > Needs someone to confirm that it actually works. it works if it compiles ;) In Fedora package I didn't do ifdefs, I just removed 0. Basically in 0.1.x it meant that you want to disable autofree, now it's default behavior without possibility to change it.
The patch should work. However, if such a version as 1.0.0 ever gets released it will fail again. I suggest the attached version instead.
Created attachment 337121 [details] [review] alternative patch for libtimidity support
Review of attachment 337121 [details] [review]: Needs to be tested by someone with new timidity ::: ext/timidity/gsttimidity.c @@ +629,3 @@ GST_DEBUG_OBJECT (timidity, "Parsing song"); +#if (LIBTIMIDITY_VERSION-0 < 0x000200L) Why -0?
(In reply to Sebastian Dröge (slomo) from comment #7) > +#if (LIBTIMIDITY_VERSION-0 < 0x000200L) > > Why -0? Just an old habit of mine for testing a value of a macro which might not actually be defined.
(In reply to Sebastian Dröge (slomo) from comment #7) > Needs to be tested by someone with new timidity It works for me, FWIW..
Comment on attachment 337121 [details] [review] alternative patch for libtimidity support Alright, let's get that in then. Can you please make this a "git format-patch" style patch with a useful commit message?
Created attachment 338282 [details] [review] reformatted patch Done.
Patch is not in yet, AFAICS. Is there anything else to be done?
We're currently in a freeze preparing for the 1.10 release, it will probably have to wait until after 1.10 is out, please ping again then if we forget.
(In reply to Tim-Philipp Müller from comment #13) > We're currently in a freeze preparing for the 1.10 release, it will probably > have to wait until after 1.10 is out, please ping again then if we forget. I wish the patch had gone into your upcoming release because it is a trivial one, but OK.
commit ae2a5f1ba928dfb61712d073b49d4cd37b5d6aa7 Author: sezero <sezero@users.sourceforge.net> Date: Sun Oct 23 12:02:00 2016 +0300 timidity: add support for libtimidity-0.2.x mid_istream_open_mem() doesn't accept an autofree argument as of libtimidity >= 0.2.0 https://bugzilla.gnome.org/show_bug.cgi?id=772503