GNOME Bugzilla – Bug 772435
batch rename: on empty names show why rename is not allowed
Last modified: 2017-05-13 16:24:14 UTC
When the destination name is empty, batch rename doesn't allow to rename by making the Rename button insensitive. But the reason why it isn't allowed is not shown (as it is, in name conflicts). How to reproduce: 1. Create some files touch {00..99} 2. Select all -> Rename -> Find and replace text 3. Set Existing text as '9'. Result: The 'Rename' button goes insensitive without explaining the user why it happened. Ideally it should show that destination name is empty, or something like that the same way as it's done with name conflicts
Created attachment 350230 [details] [review] batch-rename: show error on empty name When the destination name is empty, the "Rename" button goes insensitive without explaining the user why it happened. To explain what happened show a descriptive message to inform the user.
Review of attachment 350230 [details] [review]: LGTM, thanks!
Review of attachment 350230 [details] [review]: whops ::: src/nautilus-batch-rename-dialog.c @@ +1424,3 @@ + { + gtk_label_set_label (GTK_LABEL (dialog->conflict_label), + "File can't have an empty name"); translatioon!
Created attachment 351072 [details] [review] batch-rename: show error on empty name When the destination name is empty, the "Rename" button goes insensitive without explaining the user why it happened. To explain what happened show a descriptive message to inform the user.
Review of attachment 351072 [details] [review]: ::: src/nautilus-batch-rename-dialog.c @@ +1424,3 @@ + { + gtk_label_set_label (GTK_LABEL (dialog->conflict_label), + _("File can't have an empty name")); I don’t see any translatable string using the contraction. Also, you are not using the preferred character for apostrophes (https://developer.gnome.org/hig/stable/typography.html.en). Looking at other sources, I see a pattern in such strings. To be consistent, I’d say “A file cannot have no name” would fit better, as it also sounds more natural (at least to me). But then again, we’re entering the territory of double negatives. “A file must have a name”, perhaps? Not sure.
(In reply to Ernestas Kulik from comment #5) > Looking at other sources, I see a pattern in such strings. To be consistent, > I’d say “A file cannot have no name” would fit better, as it also sounds > more natural (at least to me). But then again, we’re entering the territory > of double negatives. “A file must have a name”, perhaps? Not sure. I like the second version better, FWIW.
Created attachment 351771 [details] [review] batch-rename: show error on empty name When the destination name is empty, the "Rename" button goes insensitive without explaining the user why it happened. To explain what happened show a descriptive message to inform the user.
Review of attachment 351771 [details] [review]: Looks good, thanks!
Attachment 351771 [details] pushed as 0e21d18 - batch-rename: show error on empty name