After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772403 - albumartcache: also consider height when scaling covers
albumartcache: also consider height when scaling covers
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-04 12:52 UTC by Georges Basile Stavracas Neto
Modified: 2016-10-04 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
albumartcache: also consider height when scaling covers (1.50 KB, patch)
2016-10-04 12:52 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Georges Basile Stavracas Neto 2016-10-04 12:52:36 UTC 
See the patch below.
Comment 1 Georges Basile Stavracas Neto 2016-10-04 12:52:40 UTC 
Created attachment 336899 [details] [review]
albumartcache: also consider height when scaling covers

When scaling down the cover artwork, the current code only understands
the case where the width of the cover is the big axis. The problem with
that is that it ends up overgrowing covers which the height is the big
axis, and breaking the layout of the Albums view.

Fix that by checking which is the biggest axis and always scaling down
the cover to fit it.
Comment 2 Marinus Schraal 2016-10-04 13:11:14 UTC 
Thanks for the quick fix.