GNOME Bugzilla – Bug 772218
Take advantage of Unicode
Last modified: 2017-02-16 01:44:54 UTC
Created attachment 336572 [details] [review] Use Unicode in translatable strings Attached patches convert ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Created attachment 345907 [details] [review] Use Unicode in translatable strings Rebased on master.
Review of attachment 345907 [details] [review]: The changes to the schema/meta_show_dialog() call are clearly fine, but I'm not sure about the other messages that go to the console/journal ... Are there any precedents for assuming unicode support there?
I don't know how it looks from the developer perspective, but I have messages in journal right now that have Unicode characters. systemd comes with a message catalog that's translated to many languages: https://github.com/systemd/systemd/tree/master/catalog and it all seems to work just fine. glib has almost all of its messages converted to Unicode: https://git.gnome.org/browse/glib/commit/?id=10c490cdfe3ae042f747bd00f787492e2bdb7ed0 and I would assume some of them go to the console and journal.
(In reply to Piotr Drąg from comment #3) > glib has almost all of its messages converted to Unicode: > https://git.gnome.org/browse/glib/commit/ > ?id=10c490cdfe3ae042f747bd00f787492e2bdb7ed0 and I would assume some of them > go to the console and journal. That's clearly a precedent, so the patch LGTM.
Comment on attachment 345907 [details] [review] Use Unicode in translatable strings Besides, if they are marked for translations, then they have Unicode on 80%+ installations. :) Thank you, pushed!