After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772199 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks: 772263
 
 
Reported: 2016-09-29 19:09 UTC by Piotr Drąg
Modified: 2016-10-03 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace three dots with ellipses in translatable strings (1.82 KB, patch)
2016-09-29 19:09 UTC, Piotr Drąg 		none Details | Review
Use Unicode in translatable strings (18.42 KB, patch)
2016-09-29 19:09 UTC, Piotr Drąg 		none Details | Review
Use Unicode in translatable strings (19.89 KB, patch)
2016-09-29 19:19 UTC, Piotr Drąg 		none Details | Review
shell: use Unicode in translatable strings (1.03 KB, patch)
2016-10-03 12:50 UTC, Piotr Drąg 		committed Details | Review
color: use Unicode in translatable strings (2.07 KB, patch)
2016-10-03 12:50 UTC, Piotr Drąg 		committed Details | Review
display: use Unicode in translatable strings (1011 bytes, patch)
2016-10-03 12:51 UTC, Piotr Drąg 		committed Details | Review
network: use Unicode in translatable strings (2.82 KB, patch)
2016-10-03 12:51 UTC, Piotr Drąg 		committed Details | Review
printers: use Unicode in translatable strings (2.62 KB, patch)
2016-10-03 12:51 UTC, Piotr Drąg 		committed Details | Review
region: use Unicode in translatable strings (1.17 KB, patch)
2016-10-03 12:51 UTC, Piotr Drąg 		committed Details | Review
user-accounts: use Unicode in translatable strings (9.83 KB, patch)
2016-10-03 12:52 UTC, Piotr Drąg 		committed Details | Review
wacom: use Unicode in translatable strings (2.08 KB, patch)
2016-10-03 12:52 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2016-09-29 19:09:24 UTC 
Created attachment 336538 [details] [review]
Replace three dots with ellipses in translatable strings

Attached patches convert ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Piotr Drąg 2016-09-29 19:09:48 UTC 
Created attachment 336540 [details] [review]
Use Unicode in translatable strings
Comment 2 Piotr Drąg 2016-09-29 19:19:54 UTC 
Created attachment 336541 [details] [review]
Use Unicode in translatable strings

Squashed the changes into one patch.
Comment 3 Bastien Nocera 2016-10-03 12:19:03 UTC 
(In reply to Piotr Drąg from comment #2)
> Created attachment 336541 [details] [review] [review]
> Use Unicode in translatable strings
> 
> Squashed the changes into one patch.

This actually needs to be split up, one patch per panel.
Comment 4 Piotr Drąg 2016-10-03 12:50:43 UTC 
Created attachment 336804 [details] [review]
shell: use Unicode in translatable strings
Comment 5 Piotr Drąg 2016-10-03 12:50:57 UTC 
Created attachment 336805 [details] [review]
color: use Unicode in translatable strings
Comment 6 Piotr Drąg 2016-10-03 12:51:12 UTC 
Created attachment 336806 [details] [review]
display: use Unicode in translatable strings
Comment 7 Piotr Drąg 2016-10-03 12:51:25 UTC 
Created attachment 336807 [details] [review]
network: use Unicode in translatable strings
Comment 8 Piotr Drąg 2016-10-03 12:51:39 UTC 
Created attachment 336808 [details] [review]
printers: use Unicode in translatable strings
Comment 9 Piotr Drąg 2016-10-03 12:51:52 UTC 
Created attachment 336809 [details] [review]
region: use Unicode in translatable strings
Comment 10 Piotr Drąg 2016-10-03 12:52:07 UTC 
Created attachment 336810 [details] [review]
user-accounts: use Unicode in translatable strings
Comment 11 Piotr Drąg 2016-10-03 12:52:22 UTC 
Created attachment 336811 [details] [review]
wacom: use Unicode in translatable strings
Comment 12 Bastien Nocera 2016-10-03 12:55:42 UTC 
Review of attachment 336804 [details] [review]:

Sure.
Comment 13 Bastien Nocera 2016-10-03 12:56:04 UTC 
Review of attachment 336805 [details] [review]:

Yes.
Comment 14 Bastien Nocera 2016-10-03 12:56:24 UTC 
Review of attachment 336806 [details] [review]:

Sure.
Comment 15 Bastien Nocera 2016-10-03 12:57:27 UTC 
Review of attachment 336807 [details] [review]:

++
Comment 16 Bastien Nocera 2016-10-03 12:58:02 UTC 
Review of attachment 336808 [details] [review]:

++
Comment 17 Bastien Nocera 2016-10-03 12:58:21 UTC 
Review of attachment 336809 [details] [review]:

Yep.
Comment 18 Bastien Nocera 2016-10-03 12:59:27 UTC 
Review of attachment 336810 [details] [review]:

Yep
Comment 19 Bastien Nocera 2016-10-03 12:59:51 UTC 
Review of attachment 336811 [details] [review]:

Fine.
Comment 20 Piotr Drąg 2016-10-03 13:23:29 UTC 
Thank you, pushed.