After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772141 - videorate: negotiation failure with input rate 0/1 drop-only=true and downstream capsfilter
videorate: negotiation failure with input rate 0/1 drop-only=true and downstr...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-28 19:49 UTC by Tim-Philipp Müller
Modified: 2018-11-03 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videorate: If drop-only=TRUE and input is 0/1, allow setting any output framerate (1.45 KB, patch)
2016-09-29 07:34 UTC, Sebastian Dröge (slomo)
none Details | Review

Description Tim-Philipp Müller 2016-09-28 19:49:30 UTC
Only happens with drop-only=true.

Reproduce with:

$ gst-launch-1.0 videotestsrc num-buffers=50 ! vp8enc ! matroskamux ! filesink location=/tmp/foo.mkv

$ gst-launch-1.0 filesrc location=/tmp/foo.mkv ! decodebin ! videorate drop-only=false ! video/x-raw,framerate=1/5 ! fakesink 

 --> works

$ gst-launch-1.0 filesrc location=/tmp/foo.mkv ! decodebin ! videorate drop-only=true ! video/x-raw,framerate=1/5 ! fakesink 

 --> not-negotiated error

(Let's ignore for now the fact that matroskamux/matroskdemux encode a rate of 0/1 here.)
Comment 1 Sebastian Dröge (slomo) 2016-09-29 07:09:35 UTC
The framerate field is not real part of the Matroska spec, it's greyed out in there. However we try to guess the framerate from the default duration... which apparently fails here
Comment 2 Sebastian Dröge (slomo) 2016-09-29 07:17:25 UTC
We do, but not for VP8. See commit 23594b0324e4bfdc153fcf89569b74bdb918c94d in -good... See bug #654379
Comment 3 Sebastian Dröge (slomo) 2016-09-29 07:34:53 UTC
Created attachment 336484 [details] [review]
videorate: If drop-only=TRUE and input is 0/1, allow setting any output framerate

We will ensure that we are always below that, but won't ensure that it's
exactly that framerate.
Comment 4 Sebastian Dröge (slomo) 2016-09-29 07:36:08 UTC
Problem here is that we won't ensure that it's exactly that framerate. The negotiation failure might be intentional. We might want to set the max-framerate field instead but that's not going to solve your negotiation failure.
Comment 5 GStreamer system administrator 2018-11-03 11:50:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/295.