GNOME Bugzilla – Bug 772090
[playlist dialog] improve interaction
Last modified: 2017-12-11 20:55:37 UTC
With the recent changes to the playlist dialog, we disregarded some interaction suggestions as seen here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/music/wire-add-to-playlist-dialog.png Please improve the current code base with these interaction fixes.
Created attachment 342037 [details] [review] playlistdialog,query,playlistview: Improved Inte... ...raction with playlists. Playlists are now shown in decreasing order of creation. Playlist dialog box is now not dismissed automatically on new playlist creation and waits for user input.
I can amend the changes in playlist ordering as needed on the basis of reviews.
Review of attachment 342037 [details] [review]: Apologies for the delayed review. This looks alright, although there have been changes that it needs adapting to: it doesn't apply cleanly anymore and it needs adapting to some recent changes. One thing I would also like to ask is to make it 2 patches, one for each of the issues fixed. They can be the same bug still, but are different issues. ::: gnomemusic/query.py @@ +255,3 @@ + ORDER BY + DESC(tracker:added(?playlist)) + !BOUND(?tag) LCASE(?title) In this case I don't mind it being on one line. If you would separate it by line you should do a line for all distinct statements (so that's 3), but nvm that and go for 1 line. I'm not quite sure the order is correct.. maybe !BOUND(?tag) still should be first, but should look into that to be sure. ::: gnomemusic/widgets/playlistdialog.py @@ -173,3 @@ - self.view.row_activated(self.model.get_path(new_iter), - self.view.get_columns()[0]) - self.dialog_box.response(Gtk.ResponseType.ACCEPT) This removal doesn't jive with the empty state dialog now implemented, because it will make it stay around and the 'create' button there sort of does seemingly nothing. So it's gonna need a special case or even just switch to the normal state and select the newly created playlist.
Created attachment 362553 [details] [review] Arrrange playlist in decreasing order of creation
Created attachment 362554 [details] [review] Playlist dialog waits for user input on new playlist creation
I can make improvements if any required on the basis of the review
Created attachment 362566 [details] [review] Arrrange playlist in decreasing order of creation Sorry for the mistake.This is the patch for arranging playlists in decreasing order of creation
Review of attachment 362566 [details] [review]: lgtm Needs a proper commit message however: see https://wiki.gnome.org/Git/CommitMessages and the commit messages in music for style.
Created attachment 362929 [details] [review] Implement playlist ordering
Review of attachment 362929 [details] [review]: I think the commit message lacks clarity, keep it short and to the point: 'Playlist are now displayed in order of creation (newest first) in the playlist dialog and view, where applicable, following the design document.' Or something along those lines.
Created attachment 362952 [details] [review] Implement playlist ordering
Review of attachment 362952 [details] [review]: lgtm, thanks for your patience :)