After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771927 - search-engine: port to use G_DECLARE* type declarations
search-engine: port to use G_DECLARE* type declarations
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 771777
 
 
Reported: 2016-09-25 08:03 UTC by Ernestas Kulik
Modified: 2016-10-07 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-engine: port to G_DECLARE* type (16.44 KB, patch)
2016-10-06 19:32 UTC, Sirbu Lavinia Stefania 		committed Details | Review

Description Ernestas Kulik 2016-09-25 08:03:01 UTC 
See bug 771777.
Comment 1 Neha Yadav 2016-10-03 10:29:42 UTC 
Help me to start with this. I followed this https://developer.gnome.org/gobject/stable/howto-gobject-code.html but need more detail to understand it properly.
Comment 2 Sirbu Lavinia Stefania 2016-10-06 19:32:23 UTC 
Created attachment 337101 [details] [review]
search-engine: port to G_DECLARE* type

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.
Comment 3 Carlos Soriano 2016-10-07 07:50:32 UTC 
Review of attachment 337101 [details] [review]:

Looks good, thanks!!
Comment 4 Ernestas Kulik 2016-10-07 13:00:56 UTC 
Attachment 337101 [details] pushed as a1b358b - search-engine: port to G_DECLARE* type