After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771906 - [patch] Task count in unscheduled panel is shown wrong
[patch] Task count in unscheduled panel is shown wrong
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-24 06:05 UTC by Mohammed Sadiq
Modified: 2016-10-25 22:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unscheduled-tasks: fix task count logic [patch] (1.74 KB, patch)
2016-09-24 06:05 UTC, Mohammed Sadiq
committed Details | Review

Description Mohammed Sadiq 2016-09-24 06:05:36 UTC
Created attachment 336189 [details] [review]
unscheduled-tasks: fix task count logic [patch]

the task count for unscheduled-task was shown wrong.

This is because the task count function was not taking care
if the task is completed or not.
Also, the plugin wasn't notifying for title changes when the task
count changed.

This commit fixes task count by counting only non completed unsheduled
tasks and notifying the application to change title on task count change.
Comment 1 Georges Basile Stavracas Neto 2016-10-06 03:35:27 UTC
Thanks for the patch!
Comment 2 Christian Stadelmann 2016-10-23 21:51:33 UTC
I'm using the most recent version from flatpak repos which identifies itself as 3.19.92 and is created from a non-existing git commit 0cf796913b8b360ed7f8569826a42b9a66414432f1517ce9f6bfbac9dd6299ad according to `flatpak --info org.gnome.Todo`. With this version, the "Unscheduled" view always counts 1 unscheduled task.

Should this be fixed already (and the push just hasn't landed in flatpak releases) or is this bug still present in another way?
Comment 3 Georges Basile Stavracas Neto 2016-10-25 22:34:14 UTC
This is fixed in the latest version of GNOME To Do. The problem with the Flatpak bundle is that Evolution-Data-Server is not compiling correctly, thus the newest version of GNOME To Do is failing to be published.