Created attachment 337113 [details] [review]
toolbar: port to G_DECLARE* type declarations

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.

Review of attachment 337113 [details] [review]:

Looks almost good, see:

::: src/nautilus-toolbar.c
@@ +518,1 @@
                                                                         (GSourceFunc) on_remove_operations_button_attention_style_timeout,

alignment is wrong now

Created attachment 337192 [details] [review]
toolbar: port to G_DECLARE* type declarations

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.

Review of attachment 337192 [details] [review]:

Quack quack.

::: src/nautilus-toolbar.c
@@ +895,3 @@
     GtkWidget *menu_popover;
 
+    // self->priv = nautilus_toolbar_get_instance (self);

What’s this? :)

::: src/nautilus-toolbar.h
@@ +43,1 @@
 					       gboolean show_location_entry);

Align the second parameter.

Created attachment 337195 [details] [review]
toolbar: port to G_DECLARE* type declarations

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.

Review of attachment 337195 [details] [review]:

Looks quack to me now! Thanks!

Attachment 337195 [details] pushed as aa0cacd - toolbar: port to G_DECLARE* type declarations