After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771604 - batch rename: Different style quotes are used at different places
batch rename: Different style quotes are used at different places
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
3.21.x
Other Linux
: Normal minor
: 3.24
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-18 01:23 UTC by Mohammed Sadiq
Modified: 2016-11-10 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
batch-rename-dialog: use same quote style (1.63 KB, patch)
2016-10-03 08:53 UTC, Alexandru Pandelea 		committed Details | Review

Description Mohammed Sadiq 2016-09-18 01:23:01 UTC 
At various places quotes styles have been mixed.

eg (line numbers may change, look for adjacent lines):
in nautilus-batch-rename-dialog.c, line 858:
      "“%s” would not be a unique new name."
   line 1421 (and following lines):
      "\"/\" is an unallowed character"

It shall be good to be consistent in using quote styles. Using “ and ” quotes shall be nice.
Comment 1 Carlos Soriano 2016-09-19 09:43:00 UTC 
Indeed
Comment 2 Alexandru Pandelea 2016-10-03 08:53:50 UTC 
Created attachment 336794 [details] [review]
batch-rename-dialog: use same quote style

Instead of using \" use “ and ”.
Comment 3 Carlos Soriano 2016-10-03 12:16:50 UTC 
Review of attachment 336794 [details] [review]:

yeah thanks!!

Don't commit it since it's a string change, so we will hold it until I branch to 3.22.
Comment 4 Carlos Soriano 2016-11-10 12:13:42 UTC 
thanks Alex!!

Attachment 336794 [details] pushed as 0fe196d - batch-rename-dialog: use same quote style