After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771364 - Filename containing '|' can't be copied to vfat filesystems
Filename containing '|' can't be copied to vfat filesystems
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-13 14:34 UTC by Mohammed Sadiq
Modified: 2018-02-18 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file-operations: forbid more characters in FAT (945 bytes, patch)
2017-09-02 09:32 UTC, Ernestas Kulik 		committed Details | Review

Description Mohammed Sadiq 2016-09-13 14:34:04 UTC 
It fails when a file whose name includes a '|' is copied to vfat filesystem.

This seems to be originally fixed in bug 309584, along with many others. The usual way is replacing '|' with '_'. This happens with characters like '*":><' etc. but not '|'
Comment 1 António Fernandes 2017-08-31 20:30:13 UTC 
Nice catch. The fix mentioned in bug 309584 is certainly commit f952bc29a3b5c1076fef916ffafd87eb8fff7a05

That patch did not include '|' in the FAT_FORBIDDEN_CHARACTERS, and this remains unchanged until this day.

I don't know if it is intentional or accidental.
Comment 2 Ernestas Kulik 2017-09-02 09:32:51 UTC 
Created attachment 358972 [details] [review]
file-operations: forbid more characters in FAT

‘\’ and ‘|’ aren’t allowed in both 8.3 and long file names.
Comment 3 Carlos Soriano 2017-09-02 19:31:14 UTC 
Review of attachment 358972 [details] [review]:

thanks!
Comment 4 Ernestas Kulik 2017-09-02 21:35:42 UTC 
Attachment 358972 [details] pushed as f4292a5 - file-operations: forbid more characters in FAT
Comment 5 Ernestas Kulik 2017-09-02 21:44:29 UTC 
Comment on attachment 358972 [details] [review]
file-operations: forbid more characters in FAT

Err… Maybe after the code freeze. :)
Comment 6 Ernestas Kulik 2017-11-29 19:44:55 UTC 
Attachment 358972 [details] pushed as 0e546d2 - file-operations: forbid more characters in FAT
Comment 7 amano 2018-02-18 02:06:03 UTC 
Ernestas, since Ubuntu is going to stick with Nautilus 3.26 for the LTS version in April, can we have this patch again on the 3.26 stable branch?

You committed it once there but had to back it out again (I think it was some freeze violation back then).
Comment 8 Ernestas Kulik 2018-02-18 07:34:49 UTC 
(In reply to amano from comment #7)
> Ernestas, since Ubuntu is going to stick with Nautilus 3.26 for the LTS
> version in April, can we have this patch again on the 3.26 stable branch?
> 
> You committed it once there but had to back it out again (I think it was
> some freeze violation back then).

I’ll look into it, thanks for the reminder.