GNOME Bugzilla – Bug 771012
Improve WebP animation-saving
Last modified: 2016-09-11 18:39:03 UTC
Created attachment 335004 [details] [review] various code improvements for WebP saving Hi, there's numerous improvements possible in file-webp-save.c code used for saving animated webp. Attached patch: - reorganizes the main loop - fixes (temporarily) the bad timestamp by using fixed 100ms delay between frames - fixes the progress bar - takes care of resource clean-up for some previously unchecked error paths - uses 'minimize_size' and 'allow_mixed' options more appropriately - only remuxes the final bytestream when ICC profile is present. For most common case, we insert the loop-count information during muxer creation instead of by remuxing at the end. thanks! skal/
Review of attachment 335004 [details] [review]: Looks good.
Thanks, pushed to master with some additional fixes: commit 342c60254697fe67d010e69f13ae09504081ca45 Author: Pascal Massimino <pascal.massimino@gmail.com> Date: Wed Sep 7 17:12:11 2016 +0200 Bug 771012 - Improve WebP animation-saving WebP saving: various improvements in file-webp-save.c - reorganizes the main loop - fixes (temporarily) the bad timestamp by using fixed 100ms delay between frames - fixes the progress bar - takes care of resource clean-up for some previously unchecked error paths - uses 'minimize_size' and 'allow_mixed' options more appropriately - only remuxes the final bytestream when ICC profile is present. For most common case, we insert the loop-count information during muxer creation instead of by remuxing at the end. plug-ins/file-webp/file-webp-save.c | 91 +++++++++++++++++++++++++++++------------------ 1 file changed, 57 insertions(+), 34 deletions(-)