GNOME Bugzilla – Bug 770990
New Plugin: Add GStreamer plugin for Intel's MediaSDK
Last modified: 2016-11-14 14:53:22 UTC
Intel's Media SDK is a cross platfrom API for developing media applications. It provides hardware acceleration for video decoding, encoding and post-processing in Intel platfroms. There is a gstreamer plugins already out under BSD3 license, https://github.com/Oblong/gst-msdk This is a proposal for merging gst-msdk to gst-plugins-bad.
Yep, let's merge after 1.10 is out. Meant to do that already, but missed the window, sorry!
I've got Oblong's plugin formulated as patches here: https://github.com/scott-d-phillips/gst-plugins-bad I'll also do a little squashing there.
Created attachment 339069 [details] [review] [PATCH gst-plugins-bad 1/6] msdk: Create plugin for Intel's Media SDK
Created attachment 339070 [details] [review] [PATCH gst-plugins-bad 2/6] msdk: add to build
Created attachment 339071 [details] [review] [PATCH gst-plugins-bad 3/6] msdk: Width and Height need to be integer multiples of 32
Created attachment 339072 [details] [review] [PATCH gst-plugins-bad 4/6] msdk: load plugins in h265 and vp8 init
Created attachment 339073 [details] [review] [PATCH gst-plugins-bad 5/6] meson: add build files for msdk
Created attachment 339074 [details] [review] [PATCH gst-plugins-bad 6/6] msdk: Initial windows build support
Created attachment 339075 [details] [review] [PATCH gst-plugins-bad v2 6/6] msdk: Initial windows build support Changes from v1: Messed up moving `#include <unistd.h>` around in first patch.
Created attachment 339082 [details] [review] [PATCH gst-plugins-bad v2 1/6] msdk: Create plugin for Intel's Media SDK Changes since v1: Removed unneeded section which was conditional on GST_CHECK_VERSION (1,8,0).
Review of attachment 339075 [details] [review]: Add msdk.c into Makefile.am too. ::: sys/msdk/msdk.c @@ +31,3 @@ + +#include "msdk.h" + Add the following for the session functions moved here. GST_DEBUG_CATEGORY_EXTERN (gst_msdkenc_debug); #define GST_CAT_DEFAULT gst_msdkenc_debug @@ +182,3 @@ + +void +_msdk_close_session (mfxSession session) Do not prefix with underscore. @@ +195,3 @@ + +mfxSession +_msdk_open_session (gboolean hardware) Do not prefix with underscore.
Created attachment 339264 [details] [review] [PATCH gst-plugins-bad v3 6/6] msdk: Initial windows build support Changes from v2: Removed underscore prefix from msdk_{open,close}_session Added msdk.c to Makefile.am
Comment on attachment 339082 [details] [review] [PATCH gst-plugins-bad v2 1/6] msdk: Create plugin for Intel's Media SDK commit 7d68d40239aa4162ff58fa63dad4baef8edc97c5 Author: Josep Torra <jtorra@oblong.com> Date: Fri Apr 1 19:25:25 2016 +0200 msdk: Create plugin for Intel's Media SDK [scott.d.phillips@intel.com: gst-indent *.c *.h] [scott.d.phillips@intel.com: link with libva at build time] [scott.d.phillips@intel.com: remove unused includes] [scott.d.phillips@intel.com: Update README] https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment on attachment 339070 [details] [review] [PATCH gst-plugins-bad 2/6] msdk: add to build commit 22551a42cc0bf31485b2b19abfe2ebadcffbfaf9 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Fri Sep 9 15:43:25 2016 -0700 msdk: add to build https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment on attachment 339071 [details] [review] [PATCH gst-plugins-bad 3/6] msdk: Width and Height need to be integer multiples of 32 commit 2905a7e33eb5618b5b505414b595bd59441fb171 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Tue Sep 27 14:17:49 2016 -0700 msdk: Width and Height need to be integer multiples of 32 https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment on attachment 339072 [details] [review] [PATCH gst-plugins-bad 4/6] msdk: load plugins in h265 and vp8 init commit 35f76fc33ae0c458505c8455dbac42f7837e0365 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Tue Sep 27 14:21:34 2016 -0700 msdk: load plugins in h265 and vp8 init https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment on attachment 339073 [details] [review] [PATCH gst-plugins-bad 5/6] meson: add build files for msdk commit 8949c12aafbbc5e3e2f49abd873690fb76091b95 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Thu Oct 13 14:30:43 2016 -0700 meson: add build files for msdk https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment on attachment 339264 [details] [review] [PATCH gst-plugins-bad v3 6/6] msdk: Initial windows build support commit 71df82db63ff9a780162d9e8eea985b2172021e0 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Thu Nov 3 10:47:00 2016 -0700 msdk: Initial windows build support https://bugzilla.gnome.org/show_bug.cgi?id=770990