After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770925 - qmlglsink: check qt_context_ first in GstQSGTexture::bind()
qmlglsink: check qt_context_ first in GstQSGTexture::bind()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-06 05:41 UTC by Haihua Hu
Modified: 2016-09-30 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check qt_context first (1.03 KB, patch)
2016-09-06 05:42 UTC, Haihua Hu 		committed Details | Review

Description Haihua Hu 2016-09-06 05:41:19 UTC 
When start qmlglsink app, it will set NULL buffer to GstQSGTexture when updatePaintNode is not triggered by qt_item_set_buffer() at start. In which case, qt_context_ will be a random value and cause gst_gl_context_activate() fail or segment fault.
Comment 1 Haihua Hu 2016-09-06 05:42:20 UTC 
Created attachment 334874 [details] [review]
check qt_context first
Comment 2 Matthew Waters (ystreet00) 2016-09-06 14:19:04 UTC 
commit f15a3e3657e19c64ae9c377e3c7b11f0428976e4
Author: Haihua Hu <jared.hu@nxp.com>
Date:   Tue Sep 6 13:13:39 2016 +0800

    qmlglsink: check qt_context_ first in GstQSGTexture::bind()
    
    When start qmlglsink app, it will set NULL buffer to GstQSGTexture
    in which case that qt_context_ will be a random value and cause
    gst_gl_context_activate() fail.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770925