After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770860 - Update screenshot in appdata
Update screenshot in appdata
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
master
Other Linux
: Normal normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks: 775215
 
 
Reported: 2016-09-05 01:20 UTC by Michael Gratton
Modified: 2017-09-29 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Gratton 2016-09-05 01:20:30 UTC
The current screenshot in geary.appdata.xml points to Yorba and is very old. It needs to be updated.
Comment 1 Niels De Graef 2016-11-28 13:56:22 UTC
In light of bug 775215, I would like to use this bug to encompass everything on updating our appdata.xml.in, since it is quite old already.

* Update the screenshot (suggestions on what screenshots we could use can be found in bug 775215)
* With GNOME software, users can read the release notes if they are included in the appdata.xml. An example can be found in GNOME Software's appdata [1] itself. If we want, we could write a script that still appends to NEWS for those not interested in reading the XML file.
* Add a URL type="translate" for interested translators. For an example, see [2].


[2] https://github.com/GNOME/gnome-software/blob/master/data/appdata/org.gnome.Software.appdata.xml.in#L45
[3] https://github.com/GNOME/gnome-software/blob/master/data/appdata/org.gnome.Software.appdata.xml.in#L626
Comment 2 Niels De Graef 2016-11-28 14:01:37 UTC
(In reply to Niels De Graef from comment #1)
> [2]
> https://github.com/GNOME/gnome-software/blob/master/data/appdata/org.gnome.
> Software.appdata.xml.in#L45
> [3]
> https://github.com/GNOME/gnome-software/blob/master/data/appdata/org.gnome.
> Software.appdata.xml.in#L626
Whoops, those should be [1] and [2] respectively.
Comment 3 Michael Gratton 2017-02-16 07:41:46 UTC
Now that UI changes are going to be pretty minimal for 0.12, this is probably worth using master as-is. Gautier, were you looking into this?
Comment 4 Gautier Pelloux-Prayer 2017-02-16 09:59:15 UTC
If Geary is ready for it, yeah I might give it a try.
Comment 5 Gautier Pelloux-Prayer 2017-02-16 14:11:55 UTC
But I think Geary is not ready yet Mike: for instance when I edit a draft it automatically closes itself after a few seconds (I think we are talk about it on Bug 777642: see your comment 6).
Anyway, would be great to add a depends on bug 775215 here.
Comment 6 Michael Gratton 2017-02-16 23:04:20 UTC
Oh, well there's a long list of bugs to fix yet, yeah, but the user interface shouldn't change itself.

I was thinking that it's maybe worth putting versioned links into the appdata file for the screenshot, so that users always see an appropriate screenshot for the version they are about to install. That would also mean we can upload screenshots to the wiki whenever they ready and just update the appdata file on master, without giving anyone any false impressions.
Comment 7 Michael Gratton 2017-09-23 11:39:30 UTC
Hey Gautier, I was wondering did you get to make any of these screenshots? I've got my phd out the way (for the moment) so would be keen to get them updated and get 0.12 out the door.
Comment 8 Gautier Pelloux-Prayer 2017-09-23 11:58:26 UTC
Good to see you again Michael :). I haven't made these because of some bugs in the mean time that prevented me from doing them - these days I'm not using Geary anymore so I won't be able to make them unfortunately.
Comment 9 Michael Gratton 2017-09-25 03:24:50 UTC
Hey Gautier, oh no problem. If you catch me on IRC I'd be interested to know what lead you jump ship, don't feel obliged to though. Sorry to lose you, but thanks for your contributions!
Comment 10 Michael Gratton 2017-09-25 13:33:22 UTC
Updated appdata to point to screenshots on the wiki in commit 8a20a45.
Comment 11 Michael Gratton 2017-09-25 14:11:43 UTC
I've also added a translate URL to the app data as suggested above in commit d6ea9a1

I wouldn't mind including release notes in the appdata as well, but since these are already duplicated in the release email, debian/changelog, and ideally on a web site somewhere (although the archived release message might work for that),  it would be good to find a solution that doesn't mean having to duplicate the release notes in 3 places instead of 2. It's maybe worth opening a new bug for that?

The two screnshots I attached are pretty basic, but at least they show the 0.12 interface and the composer, which imho is a substantial improvement. The app data points to screenshots on wiki the at the moment so they aren't duplicated in git and are hosted somewhere. Lets continue to tune the screenshots as part of revamping the wiki over in Bug 775215.
Comment 12 Niels De Graef 2017-09-29 13:41:35 UTC
About the redundancy: the `appstream-util` command provides both the appdata-to-news and news-to-appdata commands. That means that we can generate one from the other. Whether you think that's an acceptable compromise is up to you.