GNOME Bugzilla – Bug 770753
gst-libav 1.8.3 increases ffmpeg dependency vs 1.8.2
Last modified: 2017-02-04 16:26:26 UTC
Building 1.8.3 on Ubuntu xenial (ffmpeg 2.8.6) results in: gstavvidenc.c: In function ‘gst_ffmpegvidenc_register’: gstavvidenc.c:970:29: error: ‘AV_CODEC_ID_WRAPPED_AVFRAME’ undeclared (first use in this function) || in_plugin->id == AV_CODEC_ID_WRAPPED_AVFRAME) { which seems to have been introduced in: laney@raleigh (master|✔)> git tag --contains 00332e0a0 n3.0 n3.0.1 n3.0.2 n3.1 n3.1-dev n3.1.1 n3.1.2 n3.1.3 n3.2-dev ...so it has an increased ffmpeg requirement, which I suppose isn't desirable in a stable series.
I'm surprised 1.8 worked properly with ffmpeg < 3.0. But yes, that one should be made conditional on the ffmpeg version with an #ifdef. Do you want to provide a patch?
Created attachment 334659 [details] [review] Only use AV_CODEC_ID_WRAPPED_AVFRAME on new enough libavcodecs Ok then - hope this is what you had in mind. I didn't find a better thing to
#if/#ifdef on. (git-bz ate that)
Comment on attachment 334659 [details] [review] Only use AV_CODEC_ID_WRAPPED_AVFRAME on new enough libavcodecs Yes, thanks. Will merge later
Attachment 334659 [details] pushed as f5f3298 - Only use AV_CODEC_ID_WRAPPED_AVFRAME on new enough libavcodecs
This breaks wma decoding when using ffmpeg < 3.x
How is the attached patch breaking WMA decoding? Or you mean the update from 1.8.2 to 1.8.3 in one way or another broke that (please file a separate bug for that, including the exact ffmpeg version you use and how it fails).