After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770691 - Update buildroot docs
Update buildroot docs
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2016-09-01 04:36 UTC by Sébastien Wilmet
Modified: 2016-09-01 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
docs: add comment about setting buildroot to None (1006 bytes, patch)
2016-09-01 04:38 UTC, Sébastien Wilmet
committed Details | Review
docs: update buildroot documentation (1.80 KB, patch)
2016-09-01 04:38 UTC, Sébastien Wilmet
committed Details | Review

Description Sébastien Wilmet 2016-09-01 04:36:42 UTC
See the attached patches.
Comment 1 Sébastien Wilmet 2016-09-01 04:38:20 UTC
Created attachment 334581 [details] [review]
docs: add comment about setting buildroot to None

It's better to set buildroot to None instead of setting the same value
as checkoutroot.
Comment 2 Sébastien Wilmet 2016-09-01 04:38:26 UTC
Created attachment 334582 [details] [review]
docs: update buildroot documentation

The default value was changed recently.
Comment 3 Sébastien Wilmet 2016-09-01 04:40:30 UTC
For the second patch, maybe it needs to wait the string thaw.
Comment 4 Michael Catanzaro 2016-09-01 12:49:01 UTC
(In reply to Sébastien Wilmet from comment #3)
> For the second patch, maybe it needs to wait the string thaw.

Nah, jhbuild doesn't follow the GNOME release cycle.
Comment 5 Sébastien Wilmet 2016-09-01 17:23:13 UTC
Thanks for the review.

Attachment 334581 [details] pushed as 35c6a4d - docs: add comment about setting buildroot to None
Attachment 334582 [details] pushed as 63cbee0 - docs: update buildroot documentation