GNOME Bugzilla – Bug 770542
Build fixes
Last modified: 2017-05-29 16:52:23 UTC
Still not enough to get it to work in jhbuild though, the PKG_CONFIG_PATH is not set to an absolute path.
Created attachment 334353 [details] [review] build: Fix running autogen.sh outside $srcdir And use an absolute path, instead of a path relative to the sources.
Created attachment 334354 [details] [review] build: Disable Ubuntu Online Accounts support in tp-widgets Our telepathy-account-widgets submodule doesn't need support for the Ubuntu Online Accounts, so disable them instead of erroring out.
See https://git.gnome.org/browse/jhbuild/commit/?id=46cd8a904757f0a3d27963d5993b3db427a456f7
Review of attachment 334354 [details] [review]: Thanks, Bastien. Looks good.
Review of attachment 334353 [details] [review]: It doesn't break 'make distcheck'. Let's push it and see if Continuous is happy.
(In reply to Bastien Nocera from comment #0) > Still not enough to get it to work in jhbuild though, the PKG_CONFIG_PATH > is not set to an absolute path. I need to figure out how jhbuild and Continuous differ in their 'srcdir != builddir' setups. It's been on my list for a while. Haven't gotten to it, yet.
The main difference is that Continuous will call autogen.sh inside srcdir, then call configure in the builddir — whereas jhbuild calls autogen.sh in the builddir.
(In reply to Bastien Nocera from comment #0) > Still not enough to get it to work in jhbuild though, the PKG_CONFIG_PATH > is not set to an absolute path. It looks like it already works. Did you 'git clean -fdx' both the gnome-online-accounts and telepathy-account-widgets directories before trying again? (In reply to Emmanuele Bassi (:ebassi) from comment #7) > The main difference is that Continuous will call autogen.sh inside srcdir, > then call configure in the builddir — whereas jhbuild calls autogen.sh in > the builddir. I see. I did a 'git clean -fdx' in both the gnome-online-accounts and telepathy-accounts-widget directories, created a build directory in a different part of the filesystem, ran autogen.sh --enable-gtk-doc && make from there and it worked. I can even 'make distcheck' from this build directory. config.log says: PKG_CONFIG_PATH='/opt/lib/pkgconfig:/opt/lib64/pkgconfig:/opt/share/pkgconfig:telepathy-account-widgets/' ... and telepathy-account-widgets-uninstalled.pc is instantiated inside $builddir/telepathy-account-widgets.