After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770466 - Don't use deprecated GNOME_COMPILE_WARNINGS
Don't use deprecated GNOME_COMPILE_WARNINGS
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.21.x
Other Linux
: Normal normal
: 3.26
Assigned To: Ernestas Kulik
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-27 03:51 UTC by Jeremy Bicha
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don’t use GNOME_COMPILE_WARNINGS (5.61 KB, patch)
2016-08-27 07:28 UTC, Ernestas Kulik 		committed Details | Review
project: fix build warnings (17.97 KB, patch)
2016-08-30 02:08 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Jeremy Bicha 2016-08-27 03:51:28 UTC 
GNOME_COMPILE_WARNINGS is deprecated now so please don't use it. See
https://bugzilla.gnome.org/729407

gnome-calendar fails to build from source in current Debian testing or Ubuntu 16.10 Beta with gnome-common 3.18.0-2 when the packaging runs autoreconf.
Comment 1 Jeremy Bicha 2016-08-27 06:22:20 UTC 
Ignore that last sentence. I forgot to install gnome-common. It builds fine once that's installed!
Comment 2 Ernestas Kulik 2016-08-27 07:28:37 UTC 
Created attachment 334262 [details] [review]
Don’t use GNOME_COMPILE_WARNINGS

GNOME_COMPILE_WARNINGS is still being used, despite its deprecated
status. This commit also tweaks configure.ac a little, removing
redundant macro calls and definitions and quoting all macro arguments.
Comment 3 Ernestas Kulik 2016-08-27 07:30:17 UTC 
It should be noted that the patch introduces new warnings and that release builds use pretty much no warnings. Distchecking fails here due to these new warnings.
Comment 4 Georges Basile Stavracas Neto 2016-08-30 02:08:18 UTC 
Created attachment 334409 [details] [review]
project: fix build warnings
Comment 5 Georges Basile Stavracas Neto 2016-08-30 02:08:52 UTC 
Thanks for the patch.

Attachment 334262 [details] pushed as 1cb71ea - Don’t use GNOME_COMPILE_WARNINGS
Attachment 334409 [details] pushed as cd50bec - project: fix build warnings