After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770288 - clutter-script: Add an example of translation in ClutterScript
clutter-script: Add an example of translation in ClutterScript
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-23 17:09 UTC by Philip Withnall
Modified: 2016-08-24 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clutter-script: Add an example of translation in ClutterScript (2.03 KB, patch)
2016-08-23 17:09 UTC, Philip Withnall 		committed Details | Review
tests: Set locale in test-script.c (1.27 KB, patch)
2016-08-23 17:09 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2016-08-23 17:09:20 UTC 
Simple documentation update, plus a corresponding change to the test-script program to demonstrate it (or it would demonstrate translation if the strings were actually extractable and translated).
Comment 1 Philip Withnall 2016-08-23 17:09:23 UTC 
Created attachment 334024 [details] [review]
clutter-script: Add an example of translation in ClutterScript

Document the ‘translatable’ key and friends.
Comment 2 Philip Withnall 2016-08-23 17:09:28 UTC 
Created attachment 334025 [details] [review]
tests: Set locale in test-script.c

So that if the translatable strings in test-script.json are ever
translated in the .po files, they will appear translated in the test
program.

Note that for them to be translated in the .po files, they must first be
extracted by gettext, which first needs to grow support for
ClutterScript files.
Comment 3 Emmanuele Bassi (:ebassi) 2016-08-23 17:14:08 UTC 
Review of attachment 334024 [details] [review]:

LGTM
Comment 4 Emmanuele Bassi (:ebassi) 2016-08-23 17:14:31 UTC 
Review of attachment 334025 [details] [review]:

Okay.
Comment 5 Philip Withnall 2016-08-24 12:13:06 UTC 
Thanks for the fast review. Merged.

Attachment 334024 [details] pushed as 3de11d5 - clutter-script: Add an example of translation in ClutterScript
Attachment 334025 [details] pushed as 363c3f8 - tests: Set locale in test-script.c