After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770238 - Change display name of root to "/ in archive.tar.gz"
Change display name of root to "/ in archive.tar.gz"
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: archive backend
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-22 15:48 UTC by Christian Kellner
Modified: 2016-08-23 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to change display_name of archive root (604 bytes, patch)
2016-08-22 15:48 UTC, Christian Kellner 		needs-work Details | Review
archive: Fix display_name of root entry (1.20 KB, patch)
2016-08-23 12:15 UTC, Christian Kellner 		committed Details | Review

Description Christian Kellner 2016-08-22 15:48:29 UTC 
Created attachment 333921 [details] [review]
Patch to change display_name of archive root

Fixing the "FIXME" in the code:
  /* FIXME: this should really be "/ in %s", but can't change
     due to string freeze. */
Comment 1 Ondrej Holy 2016-08-23 06:11:15 UTC 
Review of attachment 333921 [details] [review]:

Thanks for the patch! Please add a comment for translators to be obvious what is meaning of this phrase, so something like:

/* Translators: This is the name of the root in an archive file, like "/ in <archive>" */

Ok to commit with such comment...
Comment 2 Christian Kellner 2016-08-23 12:15:32 UTC 
Created attachment 334001 [details] [review]
archive: Fix display_name of root entry

Change display-name file info property from "/ on XYZ" to
"/ in XYZ", as indicated by the FIXME in the code.
Comment 3 Ondrej Holy 2016-08-23 12:42:00 UTC 
Comment on attachment 334001 [details] [review]
archive: Fix display_name of root entry

commit 4fd6c8cbf42e1b740e5245fe9b352e42594d2e9b