After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770206 - css.lang: Add support for 4 and 8 digit hexadecimal color notation
css.lang: Add support for 4 and 8 digit hexadecimal color notation
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-21 16:09 UTC by Tobias Schönberg
Modified: 2016-08-21 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
css.lang: Add support for 8 and 4 digit hex color notation (1.06 KB, patch)
2016-08-21 16:14 UTC, Tobias Schönberg 		accepted-commit_now Details | Review

Description Tobias Schönberg 2016-08-21 16:09:26 UTC 
CSS now supports 8 and 4 digit hex color notation [1]. Firefox will start supporting this in version 49 and Chrome in version 52 [2]. I will attach a patch that updates the appropriate context.

[1] https://drafts.csswg.org/css-color/#hex-notation
[2] https://developer.mozilla.org/en-US/docs/Web/CSS/color_value
Comment 1 Tobias Schönberg 2016-08-21 16:14:06 UTC 
Created attachment 333825 [details] [review]
css.lang: Add support for 8 and 4 digit hex color notation

Currently 8 digit (e.g. '#aabbccff') and four digit (e.g.
'#abcf') color notation is not highlighted similar to other
hexadecimal colors.
This commit updates the 'hexadecimal-color' context to fix
the issue.
Comment 2 Sébastien Wilmet 2016-08-21 17:37:30 UTC 
Review of attachment 333825 [details] [review]:

++
Comment 3 Sébastien Wilmet 2016-08-21 17:51:37 UTC 
Pushed.