GNOME Bugzilla – Bug 770054
High bit-depth color selection widgets
Last modified: 2018-05-15 20:23:35 UTC
Hi there I was wondering whether the colour picker should enable the user to select colours with 16bit precision when a 16bit image is selected. I have created a new 16bit image but the colour picker is still displaying 0-255 values. I've asked on IRC and I was recommended to file a bug here. Is that supposed to happen? Thanks
Which color picker do you mean? I see 0-100% values in the RGB frame.
Hi Michael I was hoping to find a 16 bit colour picker. Currently the colour picker is limited to 0-255 but if Gimp is working 16 bit then it would be nice to have a 0-65537 as well?
Which dialog do you call "color picker"?
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment. Thanks!
I figured what's meant in the meantime :)
I was hunting for this bug report when commiting the following, which makes the color chooser have a range of 0.0 - 100.0 (that is roughly 10bit, not 16bit - but it leads to a UI that makes sense both in 8bpc, 16bpc and floating point modes). commit c9520bae6d6d80ba7bbe299052c0013f7e70df16 Author: Øyvind Kolås <pippin@gimp.org> Date: Wed Dec 28 19:57:28 2016 +0100 libgimpwidgets: make color chooser scales range to 100.0 instead of 255 Still using perceptual TRC - making 50% middle gray. This for all of 8bit and 16bit integer, as well as for floating point precisions. Also added a decimal point, to make use of more precision for both RGB and HSV entries.
That's already better, but I have something more flexible in mind, reopening so I can track my progress.
Setting to blocker because Mitch had a work-in-progress and that goes with all the high-bit depth changes. Obviously that should not be a definite blocker if that is the last bug standing before 2.10 release.
WIP: commit 6258d525ae6a099eb1f0ba4d436a30200c49165d Author: Michael Natterer <mitch@gimp.org> Date: Sun Dec 31 17:53:13 2017 +0100 Bug 770054 - High bit-depth color selection widgets This is WIP in the middle of cleaning up GimpColorSelector subclasses: Add the possibility to switch between LCH and LSV and between 0..100 and 0..255 RGB in to GimpColorScales. Works almost fine, but needs different UI to change the options... libgimpwidgets/gimpcolorscales.c | 619 +++++++++++++++++++++++++++++------- libgimpwidgets/gimpcolorscales.h | 10 +- 2 files changed, 521 insertions(+), 108 deletions(-)
*** Bug 778946 has been marked as a duplicate of this bug. ***
Let's call the latest state good enough for "FIXED": commit 8447e775ab5165e1bce87addbb48f332bde349f7 Author: Michael Natterer <mitch@gimp.org> Date: Mon Mar 19 22:58:03 2018 +0100 Bug 783680 - Allow to hide color models in GimpColorScales Redo the entire thing again: - Rename the values of enum GimpColorSelectorModel to include "MODEL" - Change GimpColorSelector API from set_model() to set_model_visible() so visibility of each model can be toggled individually and is not exclusive any longer - The GUI is back to what it was before, except that the "GIMP" page now honors the model visibility and has a resonable minimum height libgimpwidgets/gimpcolornotebook.c | 64 +++++++++++- libgimpwidgets/gimpcolorscales.c | 209 +++++++++++++++++++++----------------- libgimpwidgets/gimpcolorselect.c | 190 ++++++++++++++-------------------- libgimpwidgets/gimpcolorselection.c | 2 +- libgimpwidgets/gimpcolorselector.c | 190 +++++++++++++++++++++------------- libgimpwidgets/gimpcolorselector.h | 23 +++-- libgimpwidgets/gimpwidgets.def | 5 +- libgimpwidgets/gimpwidgetsenums.c | 12 +-- libgimpwidgets/gimpwidgetsenums.h | 8 +- libgimpwidgets/gimpwidgetsmarshal.list | 3 +- 10 files changed, 403 insertions(+), 303 deletions(-)