Bug 770040 – gedit segfaults in update_actions_sensitivity

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 770040 - gedit segfaults in update_actions_sensitivity


Summary:	gedit segfaults in update_actions_sensitivity


Status:	RESOLVED OBSOLETE

Product:	gedit
Classification:	Applications
Component:	file loading and saving
Version:	3.18.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Gedit maintainers
QA Contact:	Gedit maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2016-08-17 15:27 UTC by Sebastien Bacher
Modified:	2020-11-24 09:59 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Sebastien Bacher 2016-08-17 15:27:49 UTC

That's one of the most reported gedit issue on the current Ubuntu LTS but it has no user description/step to reproduce...

backtrace from a 3.18.1 report on fedora (ubuntu has some patches which might change the line numbers, https://bugzilla.redhat.com/show_bug.cgi?id=1293446) but it's still an issue with the current 3.18 version

"#0  0x00007f20a6585dd2 in update_actions_sensitivity (window=window@entry=0x5604bf1dd9f0) at gedit/gedit-window.c:611
        notebook = <optimized out>
        tab = <optimized out>
        num_notebooks = <optimized out>
        num_tabs = <optimized out>
        state = GEDIT_TAB_STATE_NORMAL
        doc = 0x0
        file = 0x0
        view = 0x0
        tab_number = -1
        action = <optimized out>
        editable = 0
        empty_search = 0
        clipboard = <optimized out>
        lockdown = <optimized out>
        enable_syntax_highlighting = <optimized out>
        __func__ = "update_actions_sensitivity"

+ Trace 236552

#1 readonly_changed
at gedit/gedit-window.c line 1929
#2 g_closure_invoke
at gclosure.c line 801
#3 signal_emit_unlocked_R
at gsignal.c line 3627
#4 g_signal_emit_valist
at gsignal.c line 3383
#5 g_signal_emit
at gsignal.c line 3439
#6 g_object_dispatch_properties_changed
at gobject.c line 1061
#7 g_object_notify_by_spec_internal
at gobject.c line 1154
#8 g_object_notify
at gobject.c line 1202
#9 _gtk_source_file_set_readonly
at gtksourcefile.c line 644
#10 gtk_source_file_loader_load_finish
at gtksourcefileloader.c line 1166
#11 load_cb
at gedit/gedit-tab.c line 1842
#12 g_task_return_now
at gtask.c line 1104
#13 g_task_return
at gtask.c line 1162
#14 g_task_return_new_error
at gtask.c line 1738
#15 close_input_stream_cb
at gtksourcefileloader.c line 482
#16 async_ready_close_callback_wrapper
at ginputstream.c line 543
#17 g_task_return_now
at gtask.c line 1104
#18 complete_in_idle_cb
at gtask.c line 1118

Comment 1 Paolo Borelli 2016-08-20 11:05:43 UTC

the fact that most of the values are 0/NULL makes me thing this happens at close.

The readonly_changed handler should get removed when a tab is removed but maybe at exit we are not removing all the tabs before disposing them?

Comment 2 Sébastien Wilmet 2020-11-24 09:59:09 UTC

Mass-closing of all gedit bugzilla tickets.

Special "code" to find again all those gedit bugzilla tickets that were open before the mass-closing:

2bfe1b0590a78457e1f1a6a90fb975f5878cb60064ccfe1d7db76ca0da52f0f3

By searching the above sha256sum in bugzilla, the gedit contributors can find again the tickets. We may be interested to do so when we work on a specific area of the code, to at least know the known problems and possible enhancements.

We do this mass-closing because bugzilla.gnome.org is being replaced by gitlab.gnome.org.