After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770030 - avfvideosrc: account for retina displays when capturing screens
avfvideosrc: account for retina displays when capturing screens
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-17 11:29 UTC by Florian Zwoch
Modified: 2016-08-19 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes retina screen support (2.18 KB, patch)
2016-08-17 11:29 UTC, Florian Zwoch 		committed Details | Review

Description Florian Zwoch 2016-08-17 11:29:21 UTC 
Created attachment 333486 [details] [review]
fixes retina screen support

This patch supports "retina" (high DPI) displays for screen capture. On "retina" displays width and height reported by CGDisplayBounds are not the correct values pixel wise for the captured image.

Instead the correct ones can be calculated by taking the "backingScalingFactor" into account from the screen being captured.

Without this patch the element will capture only capture the top left quarter of the display. That is because current retina displays have a backingScalingFactor of 2.0. So instead of 1920*2x1200*2 only 1920x1200 is being captured.
Comment 1 Alessandro Decina 2016-08-19 09:47:34 UTC 
commit 6de83e0515c334466f0e1649090c7421ea79881e
Author: Florian Zwoch <fzwoch@gmail.com>
Date:   Fri Aug 19 19:46:24 2016 +1000

    avfvideosrc: account for retina displays when capturing screens

    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=770030