After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769971 - META_PLUGIN_DECLARE contains an old-style definition
META_PLUGIN_DECLARE contains an old-style definition
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-16 10:26 UTC by Simon McVittie
Modified: 2016-08-16 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
META_PLUGIN_DECLARE: don't emit an old-style definition (1.40 KB, patch)
2016-08-16 10:26 UTC, Simon McVittie 		committed Details | Review

Description Simon McVittie 2016-08-16 10:26:13 UTC 
Created attachment 333400 [details] [review]
META_PLUGIN_DECLARE: don't emit an old-style definition

An empty argument list means "unspecified arguments", and not
"no arguments" like it does in C++. If an implementer of Mutter
plugins uses gcc -Wold-style-definition, as configured by
AX_COMPILER_FLAGS_CFLAGS, they will get warnings about this.
Comment 1 Florian Müllner 2016-08-16 10:33:40 UTC 
Review of attachment 333400 [details] [review]:

LGTM
Comment 2 Simon McVittie 2016-08-16 12:02:04 UTC 
Thanks, fixed in git for 3.21.5, eb7f332