After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769909 - Fix module path checking
Fix module path checking
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-15 07:26 UTC by Mathieu Bridon
Modified: 2016-08-15 10:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix module path checking (1.80 KB, patch)
2016-08-15 07:26 UTC, Mathieu Bridon
committed Details | Review

Description Mathieu Bridon 2016-08-15 07:26:09 UTC
The code first checks for the retro core the legacy way, for
compatibility.

If it doesn't find anything, then it's supposed to search for the core
by mimetypes.

However, the Retro.search_module funciton returns null when the module
is not found, and creating a GFile with a null path raises an assertion.

In addition, we can use the FileUtils API which is nicer for us, as it
removes the need to create a GFile.
Comment 1 Mathieu Bridon 2016-08-15 07:26:13 UTC
Created attachment 333312 [details] [review]
Fix module path checking

The code first checks for the retro core the legacy way, for
compatibility.

If it doesn't find anything, then it's supposed to search for the core
by mimetypes.

However, the Retro.search_module funciton returns null when the module
is not found, and creating a GFile with a null path raises an assertion.

In addition, we can use the FileUtils API which is nicer for us, as it
removes the need to create a GFile.
Comment 2 Adrien Plazas 2016-08-15 10:07:49 UTC
Attachment 333312 [details] pushed as 7747467 - Fix module path checking