After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769904 - gamepad: Add fallback support for gamepads without udev
gamepad: Add fallback support for gamepads without udev
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-14 23:47 UTC by Bastien Nocera
Modified: 2016-08-16 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gamepad: Add fallback support for gamepads without udev (4.72 KB, patch)
2016-08-14 23:48 UTC, Bastien Nocera
none Details | Review
gamepad: Add fallback support for gamepads without udev (5.05 KB, patch)
2016-08-15 10:48 UTC, Adrien Plazas
none Details | Review
gamepad: Add fallback support for gamepads without udev (6.94 KB, patch)
2016-08-15 15:35 UTC, Bastien Nocera
none Details | Review
gamepad: Add fallback support for gamepads without udev (7.29 KB, patch)
2016-08-16 10:27 UTC, Bastien Nocera
none Details | Review
gamepad: Add fallback support for gamepads without udev (7.24 KB, patch)
2016-08-16 13:34 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2016-08-14 23:47:49 UTC
Doesn't compile, but you get to figure it out!
Comment 1 Bastien Nocera 2016-08-14 23:48:13 UTC
Created attachment 333307 [details] [review]
gamepad: Add fallback support for gamepads without udev

udev doesn't have a stable ABI/API, so is not available in
flatpak runtimes. Add a fallback implementation that loads
the joysticks available on startup.
Comment 2 Adrien Plazas 2016-08-15 10:48:25 UTC
Created attachment 333329 [details] [review]
gamepad: Add fallback support for gamepads without udev

udev doesn't have a stable ABI/API, so is not available in
flatpak runtimes. Add a fallback implementation that loads
the joysticks available on startup.
Comment 3 Bastien Nocera 2016-08-15 15:35:56 UTC
Created attachment 333369 [details] [review]
gamepad: Add fallback support for gamepads without udev

udev doesn't have a stable ABI/API, so is not available in
flatpak runtimes. Add a fallback implementation that loads
the joysticks available on startup.
Comment 4 Mathieu Bridon 2016-08-15 21:58:59 UTC
Doesn't build when gamepad support is disabled (for example, if libevdev-devel is uninstalled).
Comment 5 Bastien Nocera 2016-08-16 10:27:45 UTC
Created attachment 333401 [details] [review]
gamepad: Add fallback support for gamepads without udev

udev doesn't have a stable ABI/API, so is not available in
flatpak runtimes. Add a fallback implementation that loads
the joysticks available on startup.

The detection code comes from the input_id.c helper in
systemd/udev, ported to libevdev.
Comment 6 Bastien Nocera 2016-08-16 13:34:41 UTC
Created attachment 333415 [details] [review]
gamepad: Add fallback support for gamepads without udev

udev doesn't have a stable ABI/API, so is not available in
flatpak runtimes. Add a fallback implementation that loads
the joysticks available on startup.

The detection code comes from the input_id.c helper in
systemd/udev, ported to libevdev.
Comment 7 Adrien Plazas 2016-08-16 15:29:15 UTC
Attachment 333415 [details] pushed as 6abbc5c - gamepad: Add fallback support for gamepads without udev